Watchlist Expiry: Decide clock icon color
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Prtksxna
	Sep 30 2020, 4:43 AM

Description

follows up on T261415: Watchlist Expiry: implement ability to see how many days left when in watchlist (mobile, advanced)

In Gerrit @Volker_E said:

Not sure, what benefit you see with this change, the visual difference is basically invisible to most users in most device contexts. It's less performant, and adds another icon. We chose in OOUI deliberately to rely on opacity and you were in support of using filters instead of custom color icons in the past.
I pledge for status quo for reasons above.
Once more, now I got to read the task. The commit message wasn't fully clear for me about the 'why' – I'd still think working with opacity makes more sense, also when we might pick up things like dark mode in the future. And the opacity icon values are part of WikimediaUI Base vars.
Not fully sure why the opacity isn't applied to the icon currently without looking into the applied CSS though.

Details

	Subject	Repo	Branch	Lines +/-
	Use actual grey clock icon instead of opacity for watchlist expiry	mediawiki/core	master	+9 -2

Customize query in gerrit

Related Objects

Mentioned In: T261415: Watchlist Expiry: implement ability to see how many days left when in watchlist (mobile, advanced)
Mentioned Here: T261415: Watchlist Expiry: implement ability to see how many days left when in watchlist (mobile, advanced)

Event Timeline

• Prtksxna created this task.Sep 30 2020, 4:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2020, 4:43 AM

Volker, I was under the impression that using a color instead of opacity would be better because:

We won't be introducing a new gray, and will be limited to what is defined in the style guide.
On different background colors (especially darker ones) the black icon with opacity won't be visible, but gray would.

I am happy either way, just wanted to make sure that I understood it properly :)

• Prtksxna added subscribers: Samwilson, ifried.Sep 30 2020, 4:48 AM

Samwilson mentioned this in T261415: Watchlist Expiry: implement ability to see how many days left when in watchlist (mobile, advanced).Sep 30 2020, 5:23 AM

Change 630714 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Use actual grey clock icon instead of opacity for watchlist expiry

https://gerrit.wikimedia.org/r/630714

gerritbot added a project: Patch-For-Review.Sep 30 2020, 5:24 AM

Thanks @Prtksxna for clarifying the problem statement.

Colors are not a strict value definition, as it's dealt with things like visual perception in context, anti-aliasing (in fonts) and other things more. Opacity seems in relation to cost of maintaining a different colored icon in several ways superior. Imagine, with the opacity value being set in WikimediaUI, we're going to change the color tone slightly tomorrow in brand refresh context. Opacity would provide us with a simple(r), central solution to that.
Different backgrounds are indeed a challenge, where I'd rely in dark mode for example on probably a more advanced way of coloring an icon like CSS/SVG filters. In this context though it seems fine to stay as is for now. And if we come to a different background, we revisit the way of dealing with opacity on black SVG icons.

Sounds good, thanks @Volker_E. We'll stick to changing only the opacity for now :)

Change 630714 abandoned by Samwilson:
[mediawiki/core@master] Use actual grey clock icon instead of opacity for watchlist expiry

Reason:
We'll stick to reduced opacity for now.