Page MenuHomePhabricator

Add link to codesearch in header
Closed, ResolvedPublic

Assigned To
Authored By
kostajh
Sep 30 2020, 9:32 AM
Referenced Files
F32369122: Screenshot at 2020-09-30 12-46-19.png
Sep 30 2020, 7:46 PM
F32368737: gerrit-admin-link-codesearch.png
Sep 30 2020, 11:34 AM
F32368627: image.png
Sep 30 2020, 9:32 AM
Tokens
"Like" token, awarded by Kizule."Like" token, awarded by Mainframe98.

Description

I would like to propose adding a link to https://codesearch.wmcloud.org/search/ in the header of our gerrit instance. I believe this is possible by customizing the header HTML in the theme https://gerrit-review.googlesource.com/Documentation/config-themes.html

image.png (179×932 px, 33 KB)

Event Timeline

Maybe that can be added under the Browse menu which is for admin links. In PolyGerrit that seems to be doable with GrAdminApi.prototype.addMenuLink.

Maybe that can be added under the Browse menu which is for admin links. In PolyGerrit that seems to be doable with GrAdminApi.prototype.addMenuLink.

That could be OK, although I have a feeling a lot of people would still miss seeing it.

Change 631174 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] gerrit: add link to codesearch

https://gerrit.wikimedia.org/r/631174

Tested locally, that looks like:

gerrit-admin-link-codesearch.png (132×436 px, 9 KB)

Change 631174 merged by Dzahn:
[operations/puppet@production] gerrit: add link to codesearch

https://gerrit.wikimedia.org/r/631174

Screenshot at 2020-09-30 12-46-19.png (196×274 px, 8 KB)

button has been added in production. (you can also use cloud first to test UI changes)

Thank you @Dzahn . @kostajh does that look right to you ? ;)

nice, thanks both!

I'm still interested to hear if a top level link is possible (and if others think it's a good idea), but this is a nice addition.

The top menu item would gives it more exposure. Then when logged in there is already four items.

As an administrator there is a fifth one for Monitoring with a single entry pointing to JavaMelody Declined task T256601: Hide the "Monitoring" tab?

I went to add it as a menu item of Browse to avoid adding yet another entry at the top.

hashar claimed this task.

That has been done a while ago as an entry under the BROWSE menu:

Screenshot at 2020-09-30 12-46-19.png (196×274 px, 8 KB)