Page MenuHomePhabricator
Create Task
Maniphest T264213

ApiThreadAction extends ApiEditPage
Open, Needs TriagePublic
Actions

Description

The ApiThreadAction class in liquid threads extends the ApiEditPage class in core
The ApiEditPage class is not stable to extend
This led to T264200: ArgumentCountError on action=help&modules=threadaction when switching the ApiEditPage class to dependency injection

Recomendation:
Rewrite ApiThreadAction to avoid using ApiEditPage

Details

SubjectRepoBranchLines +/-
ApiThreadAction: Fix conflict with DI of ApiEditPagemediawiki/extensions/LiquidThreadsmaster+29 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT259960 Inject services into API modules and special pages
 OpenNoneT264213 ApiThreadAction extends ApiEditPage

Event Timeline

DannyS712 created this task.Sep 30 2020, 4:38 PM
Restricted Application added projects: User-DannyS712, Platform Engineering. · View Herald TranscriptSep 30 2020, 4:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Sep 30 2020, 4:39 PM
DannyS712 mentioned this in T264200: ArgumentCountError on action=help&modules=threadaction.Sep 30 2020, 4:44 PM
gerritbot added a comment.Sep 30 2020, 5:32 PM

Change 631219 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/extensions/LiquidThreads@master] ApiThreadAction: Fix conflict with DI of ApiEditPage

https://gerrit.wikimedia.org/r/631219

gerritbot added a project: Patch-For-Review.Sep 30 2020, 5:32 PM
gerritbot added a comment.Sep 30 2020, 7:40 PM

Change 631219 abandoned by MusikAnimal:
[mediawiki/extensions/LiquidThreads@master] ApiThreadAction: Fix conflict with DI of ApiEditPage

Reason:
Going the less hacky route for now https://gerrit.wikimedia.org/r/c/mediawiki/core/ /631222

https://gerrit.wikimedia.org/r/631219

gerritbot added a comment.Oct 5 2020, 4:04 PM

Change 631219 restored by Ammarpad:
[mediawiki/extensions/LiquidThreads@master] ApiThreadAction: Fix conflict with DI of ApiEditPage

https://gerrit.wikimedia.org/r/631219

BPirkle edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Oct 6 2020, 5:18 PM
gerritbot added a comment.Apr 1 2021, 5:23 AM

Change 631219 abandoned by Ammarpad:

[mediawiki/extensions/LiquidThreads@master] ApiThreadAction: Fix conflict with DI of ApiEditPage

Reason:

https://gerrit.wikimedia.org/r/631219

• AMooney removed a project: Platform Team Workboards (External Code Reviews).Apr 14 2021, 7:42 PM
Umherirrender added a parent task: T259960: Inject services into API modules and special pages.Jun 29 2021, 7:28 PM
Pppery removed a project: Patch-For-Review.Apr 9 2023, 7:37 PM
Reedy moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Jun 5 2023, 12:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL