Page MenuHomePhabricator
Create Task
Maniphest T264240

Error when resetting client secret
Closed, ResolvedPublic
Actions

Description

Received a "client request failed" error when attempting to reset a client secret.

Steps to reproduce:

Related Objects

Event Timeline

apaskulin created this task.Sep 30 2020, 8:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2020, 8:49 PM
apaskulin triaged this task as High priority.Sep 30 2020, 8:50 PM
apaskulin mentioned this in T261702: Acceptance testing for WikimediaApiPortalOAuth and updates to OAuth extension.
apaskulin lowered the priority of this task from High to Low.Oct 2 2020, 5:24 PM

It seems that WikimediaApiPortalOAuth doesn't have the client_key due to T264238, so when it tries to reset the secret, it makes the request to https://meta.wikimedia.beta.wmflabs.org/w/rest.php/oauth2/client/null/reset_secret, using null in place of the missing client key. I'm reducing the priority of this to low since it's likely to be fixed by T264238

Art.tsymbar claimed this task.Oct 5 2020, 12:14 PM
Art.tsymbar added a project: Platform Team Workboards (S&F Workboard).
Art.tsymbar moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.
Art.tsymbar moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Oct 5 2020, 12:45 PM
Art.tsymbar added a project: Patch-For-Review.
Art.tsymbar added a comment.Oct 5 2020, 12:47 PM
In T264240#6513304, @apaskulin wrote:

It seems that WikimediaApiPortalOAuth doesn't have the client_key due to T264238, so when it tries to reset the secret, it makes the request to https://meta.wikimedia.beta.wmflabs.org/w/rest.php/oauth2/client/null/reset_secret, using null in place of the missing client key. I'm reducing the priority of this to low since it's likely to be fixed by T264238

True, tested locally and on the beta - works as expected. Could be closed as T264238 resolves the issue.

apaskulin closed this task as Resolved.Oct 5 2020, 2:57 PM
apaskulin removed Art.tsymbar as the assignee of this task.
apaskulin removed a project: Platform Team Workboards (S&F Workboard).
apaskulin added a subscriber: Art.tsymbar.

Resolved by T264238

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL