Page MenuHomePhabricator

Callback URI shouldn't be required for owner-only consumers
Closed, ResolvedPublic2 Estimated Story Points

Description

Expected behavior

Selecting "Bot account" should disable the Callback URI field to match the behavior on Meta

Observed behavior

After selecting "Bot account", a Callback URI is required to submit the form

Event Timeline

Change 631963 had a related patch set uploaded (by Art.tsymbar; owner: arttsymbar):
[mediawiki/extensions/WikimediaApiPortalOAuth@master] Making Callback URL not required in case of owner-only(bot) selection

https://gerrit.wikimedia.org/r/631963

Change 631963 merged by jenkins-bot:
[mediawiki/extensions/WikimediaApiPortalOAuth@master] Making Callback URL not required in case of owner-only(bot) selection

https://gerrit.wikimedia.org/r/631963

On beta, the callback URI field is no longer required, which is good. However, what we really need here is for that field to be disabled (grayed out) or hidden entirely since the current behavior on Meta doesn't support Callback URIs for owner-only clients at all. My preference would be to have the field hidden to mimic the behavior on Meta.

If it's not possible to hide it, here's the example of TextInputWidget (disabled) in OOUI. And here's a screenshot of the same:

Helga_sf set the point value for this task to 2.Oct 6 2020, 10:15 AM

Change 632757 had a related patch set uploaded (by Art.tsymbar; owner: arttsymbar):
[mediawiki/extensions/WikimediaApiPortalOAuth@master] Macking "Callback URL" ("Redirect URL") hidden when "Owner-only" ("Bot account" or "API token:...") is selected.

https://gerrit.wikimedia.org/r/632757

Change 632757 merged by jenkins-bot:
[mediawiki/extensions/WikimediaApiPortalOAuth@master] Macking "Callback URL" ("Redirect URL") hidden when "Owner-only" ("Bot account" or "API token:...") is selected.

https://gerrit.wikimedia.org/r/632757

Verified on beta. Thanks, Art!

Verified on beta. Thanks, Art!

Always welcome, Alex!