Callback URI shouldn't be required for owner-only consumers
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Expected behavior

Selecting "Bot account" should disable the Callback URI field to match the behavior on Meta

Observed behavior

After selecting "Bot account", a Callback URI is required to submit the form

Screen Shot 2020-09-30 at 2.37.12 PM.png (1×1 px, 127 KB)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikimediaApiPortalOAuth	master	+1 -0	Macking "Callback URL" ("Redirect URL") hidden when "Owner-only" ("Bot account" or "API token:...") is selected.
	mediawiki/extensions/WikimediaApiPortalOAuth	master	+6 -1	Making Callback URL not required in case of owner-only(bot) selection

Customize query in gerrit

Related Objects

Mentioned In: T261702: Acceptance testing for WikimediaApiPortalOAuth and updates to OAuth extension

Event Timeline

apaskulin created this task.Sep 30 2020, 9:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2020, 9:42 PM

apaskulin triaged this task as High priority.Sep 30 2020, 9:42 PM

apaskulin mentioned this in T261702: Acceptance testing for WikimediaApiPortalOAuth and updates to OAuth extension.Sep 30 2020, 9:45 PM

Art.tsymbar claimed this task.Oct 2 2020, 12:22 PM

Art.tsymbar added a project: Platform Team Workboards (S&F Workboard).

Art.tsymbar moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.

Change 631963 had a related patch set uploaded (by Art.tsymbar; owner: arttsymbar):
[mediawiki/extensions/WikimediaApiPortalOAuth@master] Making Callback URL not required in case of owner-only(bot) selection

https://gerrit.wikimedia.org/r/631963

gerritbot added a project: Patch-For-Review.Oct 4 2020, 11:19 AM

Art.tsymbar moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Oct 5 2020, 9:56 AM

Change 631963 merged by jenkins-bot:
[mediawiki/extensions/WikimediaApiPortalOAuth@master] Making Callback URL not required in case of owner-only(bot) selection

https://gerrit.wikimedia.org/r/631963

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 5 2020, 2:00 PM

Art.tsymbar moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Oct 5 2020, 2:01 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2020, 2:10 PM

On beta, the callback URI field is no longer required, which is good. However, what we really need here is for that field to be disabled (grayed out) or hidden entirely since the current behavior on Meta doesn't support Callback URIs for owner-only clients at all. My preference would be to have the field hidden to mimic the behavior on Meta.

If it's not possible to hide it, here's the example of TextInputWidget (disabled) in OOUI. And here's a screenshot of the same:

Screen Shot 2020-10-05 at 11.11.38 AM.png (263×935 px, 40 KB)

Helga_sf set the point value for this task to 2.Oct 6 2020, 10:15 AM

Change 632757 had a related patch set uploaded (by Art.tsymbar; owner: arttsymbar):
[mediawiki/extensions/WikimediaApiPortalOAuth@master] Macking "Callback URL" ("Redirect URL") hidden when "Owner-only" ("Bot account" or "API token:...") is selected.

https://gerrit.wikimedia.org/r/632757

gerritbot added a project: Patch-For-Review.Oct 7 2020, 4:38 PM

Art.tsymbar moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Oct 7 2020, 4:48 PM

Change 632757 merged by jenkins-bot:
[mediawiki/extensions/WikimediaApiPortalOAuth@master] Macking "Callback URL" ("Redirect URL") hidden when "Owner-only" ("Bot account" or "API token:...") is selected.

https://gerrit.wikimedia.org/r/632757

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.13; 2020-10-12); removed MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 7 2020, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2020, 8:10 PM

Verified on beta. Thanks, Art!

In T264248#6527308, @apaskulin wrote:

Verified on beta. Thanks, Art!

Always welcome, Alex!

Callback URI shouldn't be required for owner-only consumersClosed, ResolvedPublic2 Estimated Story PointsActions