Page MenuHomePhabricator

[BUG] Mobile newcomer homepage: Suggested edits preview illustration is displaying incorrectly
Closed, InvalidPublicBUG REPORT

Description

Graphic is the wrong size on all wikis, with related padding issues, and wrapping incorrectly on arwiki (and presumably all RTL languages)

Steps to Reproduce:
Go to the newcomer homepage on arwiki

Actual Results:

image.png (352×672 px, 23 KB)

Expected Results:

image.png (450×600 px, 26 KB)

a. Suggested edits illustration should be 64x64px

  • This may be solved by adding a height:64px attribute to .growthexperiments-homepage-module-suggested-edits.growthexperiments-homepage-module-mobile-summary .suggested-edits-main .suggested-edits-icon

b. Space between illustration and number of Suggested edits should only by 16px
c. Illustration is not right-aligned with the module header text the RTL arwiki

  • Parts b. and c. seems to be solvable by changing padding-left:16px (padding-right on LTR wikis) on .growthexperiments-homepage-module-suggested-edits.growthexperiments-homepage-module-mobile-summary .suggested-edits-main .suggested-edits-icon to margin-left:16px (margin-right on LTR wikis) instead.

Event Timeline

@RHo -- we only use this graphic for the mobile preview in Variant A, right? We should still fix it, but trying to decide if it's needed for Variants C and D.

We use it in variant C/D when there is no preview task to show.

De-prioritizing off the sprint board in favor of other priorities.

kostajh subscribed.

I assume this is no longer an issue.