Page MenuHomePhabricator
Create Task
Maniphest T264282

Remove wb_terms-related code (e. g. Term(Sql)Index)
Closed, ResolvedPublic
Actions

Description

At this point, the TermIndex interface and TermSqlIndex class should be unused; if they haven’t been deleted yet as part of another task, remove them now. (If they’re not unused yet, remove anything else that still couples to them.)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+10 -6Remove or update occurrences of “term index”
mediawiki/extensions/Wikibasemaster+10 -1 Kwb_terms: remove termindex and related classes and methods
mediawiki/extensions/Wikibasemaster+0 -2 Kwb_terms: remove TermSqlIndex
mediawiki/extensions/Wikibasemaster+0 -815wb_terms: remove TermSqlIndexBuilder
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 1 2020, 8:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2020, 8:37 AM
Addshore added a project: Story.Oct 1 2020, 8:38 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 1 2020, 8:59 AM
Lucas_Werkmeister_WMDE moved this task from Backlog to To do on the Wikibase wb_terms leftovers 2020 board.
toan claimed this task.Oct 5 2020, 4:57 PM
toan moved this task from To do to Doing on the Wikibase wb_terms leftovers 2020 board.
toan moved this task from Doing to To do on the Wikibase wb_terms leftovers 2020 board.Oct 6 2020, 8:39 AM
gerritbot added a comment.Oct 6 2020, 9:21 AM

Change 632297 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] wb_terms: remove TermSqlIndexBuilder

https://gerrit.wikimedia.org/r/632297

gerritbot added a project: Patch-For-Review.Oct 6 2020, 9:21 AM

Change 632295 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] WIP: wb_terms: remove TermSqlIndex

https://gerrit.wikimedia.org/r/632295

gerritbot added a comment.Oct 6 2020, 10:27 AM

Change 632297 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wb_terms: remove TermSqlIndexBuilder

https://gerrit.wikimedia.org/r/632297

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 6 2020, 11:00 AM
toan moved this task from To do to Doing on the Wikibase wb_terms leftovers 2020 board.Oct 7 2020, 8:08 AM
toan moved this task from Doing to Peer Review on the Wikibase wb_terms leftovers 2020 board.Oct 7 2020, 1:47 PM
Lucas_Werkmeister_WMDE closed subtask T264761: Remove clearTermSqlIndexSearchFields.php repo maintenance script as Resolved.Oct 7 2020, 2:24 PM
gerritbot added a comment.Oct 7 2020, 2:29 PM

Change 632295 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wb_terms: remove TermSqlIndex

https://gerrit.wikimedia.org/r/632295

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2020, 3:10 PM
gerritbot added a comment.Oct 8 2020, 11:22 AM

Change 632695 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] wb_terms: remove termindex and related classes and methods

https://gerrit.wikimedia.org/r/632695

gerritbot added a project: Patch-For-Review.Oct 8 2020, 11:22 AM
gerritbot added a comment.Oct 8 2020, 1:00 PM

Change 632695 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wb_terms: remove termindex and related classes and methods

https://gerrit.wikimedia.org/r/632695

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikibase wb_terms leftovers 2020 board.Oct 8 2020, 2:57 PM

The classes TermIndexEntry and TermIndexSearchCriteria still exist and refer to “the term index”. Should we rename/adjust them somehow?

gerritbot added a comment.Oct 12 2020, 4:39 PM

Change 633563 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove or update occurrences of “term index”

https://gerrit.wikimedia.org/r/633563

Lucas_Werkmeister_WMDE claimed this task.Oct 12 2020, 4:39 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Peer Review on the Wikibase wb_terms leftovers 2020 board.
Lucas_Werkmeister_WMDE added a subscriber: toan.
Addshore added a subscriber: Addshore.Oct 13 2020, 8:45 AM

One patch remaining here (I just rechecked it now)

gerritbot added a comment.Oct 13 2020, 3:14 PM

Change 633563 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove or update occurrences of “term index”

https://gerrit.wikimedia.org/r/633563

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikibase wb_terms leftovers 2020 board.Oct 13 2020, 3:55 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.14; 2020-10-20); removed MW-1.36-notes (1.36.0-wmf.13; 2020-10-12).Oct 13 2020, 4:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 14 2020, 2:23 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase wb_terms leftovers 2020 board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL