Page MenuHomePhabricator

Remove wb_terms-related code (e. g. Term(Sql)Index)
Closed, ResolvedPublic

Description

At this point, the TermIndex interface and TermSqlIndex class should be unused; if they haven’t been deleted yet as part of another task, remove them now. (If they’re not unused yet, remove anything else that still couples to them.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2020, 8:37 AM
toan claimed this task.Oct 5 2020, 4:57 PM
toan moved this task from To do to Doing on the Wikibase wb_terms leftovers 2020 board.

Change 632297 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] wb_terms: remove TermSqlIndexBuilder

https://gerrit.wikimedia.org/r/632297

Change 632295 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] WIP: wb_terms: remove TermSqlIndex

https://gerrit.wikimedia.org/r/632295

Change 632297 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wb_terms: remove TermSqlIndexBuilder

https://gerrit.wikimedia.org/r/632297

Change 632295 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wb_terms: remove TermSqlIndex

https://gerrit.wikimedia.org/r/632295

Change 632695 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] wb_terms: remove termindex and related classes and methods

https://gerrit.wikimedia.org/r/632695

Change 632695 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wb_terms: remove termindex and related classes and methods

https://gerrit.wikimedia.org/r/632695

The classes TermIndexEntry and TermIndexSearchCriteria still exist and refer to “the term index”. Should we rename/adjust them somehow?

Change 633563 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove or update occurrences of “term index”

https://gerrit.wikimedia.org/r/633563

One patch remaining here (I just rechecked it now)

Change 633563 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove or update occurrences of “term index”

https://gerrit.wikimedia.org/r/633563