Page MenuHomePhabricator

German Wikivoyage: select modern Vector skin as default
Closed, DuplicatePublic

Assigned To
None
Authored By
RolandUnger
Oct 1 2020, 11:40 AM
Referenced Files
F34084244: image.png
Feb 1 2021, 8:51 PM
F34084241: image.png
Feb 1 2021, 8:51 PM
F34083548: Screen Shot 2021-02-01 at 12.02.48 PM.png
Feb 1 2021, 8:02 PM
F34083543: Screen Shot 2021-02-01 at 11.59.58 AM.png
Feb 1 2021, 8:02 PM
F34083545: Screen Shot 2021-02-01 at 12.01.13 PM.png
Feb 1 2021, 8:02 PM
F34083541: Screen Shot 2021-02-01 at 11.59.41 AM.png
Feb 1 2021, 8:02 PM
F34083323: en-wordmark.svg
Feb 1 2021, 5:09 PM
F34083321: wikivoyage-icon.svg
Feb 1 2021, 4:48 PM
Tokens
"Love" token, awarded by Volker_E.

Description

NOTE: Make sure logo change in T273477 is done first.

Background

The readers of the German Wikivoyage decided to switch the desktop skin from Legacy Vector to modern Vector. I think the following parameters has to be set:

$wgVectorDefaultSkinVersion = 2
wgVectorDefaultSkinVersionForNewAccounts = 2

Please set the default vector skin for users who have not made a preference selection, too.

The result of the survey can be found on https://de.wikivoyage.org/wiki/Wikivoyage:Lounge#Umfragen (first topic "Skin")

Acceptance criteria

  • Deploy modern Vector skin as default on dewikivoyage

Event Timeline

Urbanecm moved this task from Backlog to External on the Wikimedia-Site-requests board.
Urbanecm added subscribers: Jdlrobson, Urbanecm.

@Jdlrobson Could you please make sure this gets processed by Readers Web Team? Thanks!

@ovasileva is this blocked on anything or can I do this in the next backport window?

@ovasileva is this blocked on anything or can I do this in the next backport window?

@Jdlrobson - I think @alexhollender wanted to do some more work on T252701: Spike: what to do with Wikivoyage icons in new design? first. I'll add it as a blocker. @alexhollender - let me know if that's not the case and we can go ahead.

ovasileva changed the task status from Open to Stalled.Jan 13 2021, 5:24 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Moving to triaged but future - will move back to upcoming once we have the new logos from T252701: Spike: what to do with Wikivoyage icons in new design?

Jdlrobson changed the task status from Stalled to Open.Feb 1 2021, 4:27 PM
In T264299#6792136, @alexhollender wrote:

@ovasileva @Jdlrobson since https://de.wikivoyage.org/wiki/Hauptseite is using the English version of the Wikivoyage logo, I believe we can close this and use the SVGs in T273477

YAY! So the new logo would be

, right? Adding to description

YAY! So the new logo would be

I think there's a little confusion here.

On modern Vector we actually construct the logo from several parts.
On WIkivoyage rather than constructing a logo from an icon and a wordmark we use a wordmark which includes a logo like this:

Screen Shot 2021-02-01 at 12.01.13 PM.png (250×1 px, 38 KB)

We do this because on mobile the wordmark currently looks like this:

Screen Shot 2021-02-01 at 11.59.41 AM.png (186×1 px, 21 KB)

This is inconsistent from Wikipedia which just shows the logo ''text'':
http://en.m.wikipedia.org

Screen Shot 2021-02-01 at 12.02.48 PM.png (174×554 px, 21 KB)

So when enabling we have two choices:

  1. Retain existing behaviour and show https://en.wikivoyage.org/?useskin=vector&useskinversion=2
  2. Disable the logo on Wikivoyage mobile site (in which case we need an asset for the text ("Wikivoyage") not the icon.

@Jdlrobson right, thanks for the reminder/clarification that we are not currently displaying the "icon" element on mobile. I've updated the screenshots in the description here and on T273477

I think this is now a duplicate of T273090 and should be merged into that task.