Page MenuHomePhabricator

Undefined index: DisableUTEdit in Special:InvestigateBlock on itwiki
Closed, ResolvedPublic

Description

SpecialInvestigateBlock::onSubmit assumes that the DisableUTEdit field is present. However, it is not present on itwiki, which has $BlockAllowsUTEdit = false.

Stack trace:

#0 /srv/mediawiki/php-1.36.0-wmf.10/extensions/CheckUser/src/SpecialInvestigateBlock.php(226): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.10/includes/htmlform/HTMLForm.php(707): MediaWiki\CheckUser\SpecialInvestigateBlock->onSubmit(array, OOUIHTMLForm)
#2 /srv/mediawiki/php-1.36.0-wmf.10/includes/htmlform/HTMLForm.php(597): HTMLForm->trySubmit()
#3 /srv/mediawiki/php-1.36.0-wmf.10/includes/htmlform/HTMLForm.php(613): HTMLForm->tryAuthorizedSubmit()
#4 /srv/mediawiki/php-1.36.0-wmf.10/includes/specialpage/FormSpecialPage.php(187): HTMLForm->show()
#5 /srv/mediawiki/php-1.36.0-wmf.10/includes/specialpage/SpecialPage.php(600): FormSpecialPage->execute(NULL)
#6 /srv/mediawiki/php-1.36.0-wmf.10/includes/specialpage/SpecialPageFactory.php(692): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#8 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(940): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(543): MediaWiki->main()
#10 /srv/mediawiki/php-1.36.0-wmf.10/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-1.36.0-wmf.10/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

Event Timeline

Change 631435 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] SpecialInvestigateBlock: Don't assume 'DisableUTEdit' exists

https://gerrit.wikimedia.org/r/631435

Change 631435 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] SpecialInvestigateBlock: Don't assume 'DisableUTEdit' exists

https://gerrit.wikimedia.org/r/631435

Change 631466 had a related patch set uploaded (by Jforrester; owner: Tchanders):
[mediawiki/extensions/CheckUser@wmf/1.36.0-wmf.11] SpecialInvestigateBlock: Don't assume 'DisableUTEdit' exists

https://gerrit.wikimedia.org/r/631466

Change 631478 had a related patch set uploaded (by Dbarratt; owner: Tchanders):
[mediawiki/extensions/CheckUser@wmf/1.36.0-wmf.10] SpecialInvestigateBlock: Don't assume 'DisableUTEdit' exists

https://gerrit.wikimedia.org/r/631478

The MW-1.36-notes (1.36.0-wmf.11; 2020-09-29) train has been held, per the policy we are unable to deploy this fix to production at this time.

Niharika added a subscriber: Niharika.

I'll add this to the sprint because it is under active work.

Thanks @Niharika - moved to QA since the fix has been merged, and I don't think a backport will be possible before it rolls out on the next train.

Urbanecm added a subscriber: Urbanecm.

seems this is all done?

Change 631478 abandoned by DannyS712:
[mediawiki/extensions/CheckUser@wmf/1.36.0-wmf.10] SpecialInvestigateBlock: Don't assume 'DisableUTEdit' exists

Reason:
I guess this wasn't deployed? No longer needed since all sites are now at 1.36.0-wmf.14

https://gerrit.wikimedia.org/r/631478

Change 631466 abandoned by DannyS712:
[mediawiki/extensions/CheckUser@wmf/1.36.0-wmf.11] SpecialInvestigateBlock: Don't assume 'DisableUTEdit' exists

Reason:
I guess this wasn't deployed? No longer needed since all sites are now at 1.36.0-wmf.14

https://gerrit.wikimedia.org/r/631466