Page MenuHomePhabricator

Can't paste-to-upload in VE
Closed, ResolvedPublic

Description

When you paste-to-upload in VE, the UI takes whatever filename the browser API gives it, which for a paste is usually just "Image".

The upload API then stashes this file, and comes back with a warning that the filename exists. This should still be considered a success because the name at this point has not been finalised, but seemingly it isn't, and accordingly the UI does not let you continue:

After pasteAfter "Upload"
image.png (338×517 px, 28 KB)
image.png (308×496 px, 29 KB)

Expected
No error is show unless you try to finalise the upload with an invalid filename (i.e. after pressing "Save" on the second panel)

Testing notes

Attempt to add an image to VE by way of copy and paste. After doing so, observe you are asked to name the file and then proceed with the upload flow.

Note: no need to test saving as part of this ticket.

Event Timeline

Change 631506 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Fix typo in upload API

https://gerrit.wikimedia.org/r/631506

Change 631506 merged by jenkins-bot:
[mediawiki/core@master] Fix typo in upload API

https://gerrit.wikimedia.org/r/631506

Change 639469 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/core@master] Pass along ignorewarnings param to all individual chunks being uploaded

https://gerrit.wikimedia.org/r/639469

Change 639469 merged by jenkins-bot:
[mediawiki/core@master] Pass along ignorewarnings param to all individual chunks being uploaded

https://gerrit.wikimedia.org/r/639469

Change 639953 had a related patch set uploaded (by Tim Starling; owner: Matthias Mullie):
[mediawiki/core@wmf/1.36.0-wmf.16] Pass along ignorewarnings param to all individual chunks being uploaded

https://gerrit.wikimedia.org/r/639953

Change 639955 had a related patch set uploaded (by Tim Starling; owner: Matthias Mullie):
[mediawiki/core@wmf/1.36.0-wmf.14] Pass along ignorewarnings param to all individual chunks being uploaded

https://gerrit.wikimedia.org/r/639955

Change 639953 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.16] Pass along ignorewarnings param to all individual chunks being uploaded

https://gerrit.wikimedia.org/r/639953

Change 639955 merged by Tim Starling:
[mediawiki/core@wmf/1.36.0-wmf.14] Pass along ignorewarnings param to all individual chunks being uploaded

https://gerrit.wikimedia.org/r/639955

Change 639960 had a related patch set uploaded (by Reedy; owner: Esanders):
[mediawiki/core@REL1_35] Fix typo in upload API

https://gerrit.wikimedia.org/r/639960

Change 639961 had a related patch set uploaded (by Reedy; owner: Matthias Mullie):
[mediawiki/core@REL1_35] Pass along ignorewarnings param to all individual chunks being uploaded

https://gerrit.wikimedia.org/r/639961

Change 639960 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix typo in upload API

https://gerrit.wikimedia.org/r/639960

Change 639961 merged by jenkins-bot:
[mediawiki/core@REL1_35] Pass along ignorewarnings param to all individual chunks being uploaded

https://gerrit.wikimedia.org/r/639961