Page MenuHomePhabricator
Create Task
Maniphest T264366

Uncaught TypeError: Cannot read property 'getItem' of null
Closed, ResolvedPublic
Actions

Description

2030 errors were thrown on mobile French Wikipedia in the last 12 hrs. This is extremely high - in fact is occurring more than any other error.

The banner looks like it was turned on at 4pm UTC yesterday.

Screen Shot 2020-10-01 at 2.33.47 PM.png (382×2 px, 64 KB)

Debugging is tricky, but I strongly believe this relates to a new campaign on French Wikipedia. The error is likely preventing the banner from displaying.

This error possibly relates to:
https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B2021_1002_frFR_m_p1_lg_txt_swap

which uses localStorage without any kind of feature detection.

Acceptance criteria

  • The bug is fixed
  • An update is made to the banner loader such that it's easier to identify errors coming from banners. I would recommend a named function e.g. insertCentralNoticeBannerHTML(); so that this appears in the stacktrace
at HTMLDocument.<anonymous>  <anonymous>:1863:41
at mightThrow  URL1:161:149
at process  URL1:161:808

URL1: https://fr.m.wikipedia.org/w/load.php?lang=fr&modules=ext.centralNotice.bannerHistoryLogger%2CchoiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2ClargeBannerLimit%2ClegacySupport%2CstartUp%7Cext.centralauth.centralautologin%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.quicksurveys.init%2Clib%7Cext.relatedArticles.readMore.bootstrap%2Cgateway%7Cjquery%2Coojs%2Coojs-router%2Coojs-ui-core%2Coojs-ui-widgets%2Csite%7Cjquery.client%2Ccookie%2Cthrottle-debounce%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctemplate%2Cuser%2Cutil%2Cviewport%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%7Cmediawiki.ui.anchor%7Cmobile.init%2Cstartup%7Cmobile.messageBox.styles%7Cmobile.ooui.icons%7Cmobile.pagelist.styles%7Cmobile.pagesummary.styles%7Cmobile.placeholder.images%7Cmobile.startup.images%7Cmw.externalguidance.init%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui.styles.indicators%7Cskins.minerva.icons.images.scripts%7Cskins.minerva.icons.images.scripts.misc%7Cskins.minerva.icons.page.issues.default.color%7Cskins.minerva.icons.page.issues.medium.color%7Cskins.minerva.icons.page.issues.uncolored%7Cskins.minerva.options%2Cscripts%7Cuser.defaults&skin=minerva&version=1jnxh
`

Related Objects

Event Timeline

Jdlrobson created this task.Oct 1 2020, 9:36 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 1 2020, 9:36 PM
Jdlrobson triaged this task as Unbreak Now! priority.Oct 1 2020, 9:36 PM

Possibly not unbreak now, but not sure as I don't know much about this banner campaign. Hopefully, someone in fundraising can confirm and update accordingly.

Given this doesn't concern production code this doesn't block the current deployment.

Restricted Application added a subscriber: Pcoombe. · View Herald TranscriptOct 1 2020, 9:36 PM
Jdlrobson added a comment.EditedOct 1 2020, 9:39 PM

I'm also seeing the error NS_ERROR_FILE_CORRUPTED: on French Wikipedia which is likely related based on the timeframe.
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.10.01/clienterror/?id=AXTl-f50LNRtRo5XPxEt

• jbolorinos-ctr subscribed.Oct 1 2020, 9:40 PM
• DStrine added a project: Fundraising-Backlog.Oct 1 2020, 9:54 PM
Pcoombe mentioned this in T264375: Make it easier to identify client side errors from CentralNotice banners in logs.Oct 1 2020, 10:40 PM
Pcoombe lowered the priority of this task from Unbreak Now! to High.Oct 1 2020, 10:47 PM

Thanks for spotting this @Jdlrobson. We did indeed launch our France campaign at 4pm UTC. 2000 errors is actually pretty small in the context of how many banners we're showing, but it's great that we can now catch these things. I've split out T264375: Make it easier to identify client side errors from CentralNotice banners in logs as a separate task since that will need CentralNotice work rather than just editing our banners.

For now I've just removed this particular bit of code from all our banners which are live, since none of them are actually making use of it. example diff. Leaving this task open to add proper feature detection in case we do want to use this code in other banners.

Jdlrobson updated the task description. (Show Details)Oct 1 2020, 11:39 PM

Nice! I can confirm the drop off!

Screen Shot 2020-10-01 at 4.38.54 PM.png (518×2 px, 82 KB)

Thanks for the bug fix.

I'm happy to help you setup a dashboard once we have a reliable way to detect these errors from a stack trace :)

• Icloudi329 removed projects: Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error.Oct 1 2020, 11:44 PM
• Icloudi329 updated the task description. (Show Details)
• Icloudi329 removed subscribers: • jbolorinos-ctr, Pcoombe, Aklapper and 2 others.
Ejegg subscribed.Oct 1 2020, 11:45 PM

There's some feature detection in the CentralNotice.kvStore library, but it's not fully exposed:

https://phabricator.wikimedia.org/diffusion/ECNO/browse/wmf_deploy/resources/ext.centralNotice.kvStore/kvStore.js$74

There's also the ext.centralNotice.kvStore.getItem function as used inside the impression diet mixin:

https://phabricator.wikimedia.org/diffusion/ECNO/browse/wmf_deploy/resources/subscribing/ext.centralNotice.impressionDiet.js$207

That multiStorageOption variable is set up here: https://phabricator.wikimedia.org/diffusion/ECNO/browse/wmf_deploy/resources/subscribing/ext.centralNotice.impressionDiet.js$57

• DStrine added projects: Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error.Oct 1 2020, 11:51 PM
• DStrine updated the task description. (Show Details)
• DStrine added subscribers: • jbolorinos-ctr, Pcoombe, Masumrezarock100 and 2 others.
RhinosF1 subscribed.Oct 2 2020, 5:44 AM
Krinkle moved this task from Untriaged to Oct 2020 on the Wikimedia-production-error board.Oct 4 2020, 11:16 PM
Umherirrender added a project: JavaScript.Oct 5 2020, 5:01 PM
• DStrine moved this task from Triage to Blocked or not fr-tech on the Fundraising-Backlog board.Oct 5 2020, 8:16 PM
Pcoombe closed this task as Resolved.Oct 6 2020, 8:31 PM
Pcoombe claimed this task.

I updated our banners which do use this to add some feature detection. This should deal with the NS_ERROR_FILE_CORRUPTED issue too, which appears to be a Firefox issue: https://stackoverflow.com/questions/18877643/error-in-local-storage-ns-error-file-corrupted-firefox/26371494

Thanks @Ejegg for the code suggestion!

if ( localStorage ) {
    try {
        // TODO: make this general for any identifier, not just 2020
        var lsName = 'CentralNoticeKV|global|impression_diet_bannercount_fundraiser_2020';
        var diet = JSON.parse( localStorage.getItem( lsName ) );
        if ( diet ) {
            var seenCount = diet.val.seenCount;
            $( '.frb-replace-seenCount' ).text( seenCount );
            $( '.frb-replace-seenCount-ordinalNum' ).text( ordinalNums[ seenCount ] );
            $( '.frb-replace-seenCount-ordinalWord' ).text( ordinalWords[ seenCount ] );
        }
    } catch ( ex ) {
        // do nothing - localStorage is configured not to let us read it
    }
}
Jdlrobson awarded a token.Oct 6 2020, 10:31 PM
• jbolorinos-ctr mentioned this in T264934: 2020-10-08 en6C pre-test: mobile large batch.Oct 7 2020, 8:06 PM
Pcoombe mentioned this in T267267: Banner on German Wikipedia and wikidata.org throwing NS_ERROR_FILE_CORRUPTED: error.Nov 5 2020, 5:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL