Page MenuHomePhabricator

Wikibase client Scribunto tests are broken
Closed, ResolvedPublic

Description

With 7bb47b6 (which changed the default Wikibase client term store to MIGRATE_NEW) the Wikibase client Scribunto tests broke.

This is caused by Scribunto_LuaWikibaseLibraryTestCase::primeTermsTable not supporting the new term storage, thus enabling it broke the tests.

Side note: Why is this passing on Jenkins, is it hard coded to use the old term store there? Does it skip the Scribunto tests (yikes)?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Side note: Why is this passing on Jenkins … Does it skip the Scribunto tests (yikes)?

Yes, Wikibase CI is “temporarily” running without Scribunto and Capiunto (I1c68b9bdff, T231198) – and “temporarily” here means “for a little over a year now” 😶

Change 631781 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Update term store priming in Scribunto_LuaWikibaseLibraryTestCase

https://gerrit.wikimedia.org/r/631781

Change 631781 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Override PropertyLabelResolver in Scribunto_LuaWikibaseLibraryTestCase

https://gerrit.wikimedia.org/r/631781

Change 632021 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Hoo man):
[mediawiki/extensions/Wikibase@REL1_35] Override PropertyLabelResolver in Scribunto_LuaWikibaseLibraryTestCase

https://gerrit.wikimedia.org/r/632021

Change 632021 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Override PropertyLabelResolver in Scribunto_LuaWikibaseLibraryTestCase

https://gerrit.wikimedia.org/r/632021

Travis builds for both the master and REL1_35 branches are fixed now.