Maniphest T264389

ProofreadPageContent must not contain User object, since it cannot be serialized safely.
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	daniel
	Oct 2 2020, 7:51 AM

Tags

Referenced Files

None

Subscribers

Description

ProofreadPage's PageContent gets serialized by PageEditStash. It contains a PageLevel, which contains a User object. This could be replaced with a UserIdentityValue, at least for serialization. PageContent actually already has special code for handing the User object when serializing to JSON for storage. This just isn't used when it's serialized via PHP's native serialization for caching.

This issue caused a production error, see T264363: Instances of User are not serializable!.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make Content JsonCodecable	mediawiki/core	REL1_43	+441 -2
	Make Content JsonCodecable	mediawiki/core	REL1_44	+441 -2
	Make Content JsonCodecable	mediawiki/core	master	+441 -2
	Prepare to use JSON serialization for PageEditStash	mediawiki/core	master	+333 -92

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T274189 Remove usage of PHP serialization from WANObjectCache
		Open		None	T264393 Mark user object as non-serializable
		Open		None	T264389 ProofreadPageContent must not contain User object, since it cannot be serialized safely.
		Resolved		tstarling	T264391 FeaturedFeedChannel must not contain a User object, since it cannot be serialized safely.

Event Timeline

daniel created this task.Oct 2 2020, 7:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2020, 7:51 AM

daniel mentioned this in T264363: Instances of User are not serializable!.Oct 2 2020, 7:55 AM

daniel mentioned this in T264393: Mark user object as non-serializable.Oct 2 2020, 7:58 AM

daniel added a parent task: T264393: Mark user object as non-serializable.

DannyS712 subscribed.Oct 2 2020, 12:45 PM

BPirkle moved this task from Inbox to Future Initiatives/Small Projects on the Platform Engineering board.Oct 6 2020, 8:41 PM

Naike edited projects, added Platform Engineering Roadmap Decision Making; removed Platform Engineering.Oct 8 2020, 8:49 PM

Naike moved this task from Untriaged to Icebox on the Platform Engineering Roadmap Decision Making board.Nov 16 2020, 3:23 PM

daniel added a parent task: T274189: Remove usage of PHP serialization from WANObjectCache.Feb 8 2021, 9:01 PM

Change #1165581 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Use JSON serialization for PageEditStash

https://gerrit.wikimedia.org/r/1165581

Change #1165592 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Make Content JsonCodecable

https://gerrit.wikimedia.org/r/1165592

cscott mentioned this in T398656: PageEditStash (and Content) should use JSON serialization.Jul 3 2025, 6:28 PM

Change #1165581 merged by jenkins-bot:

[mediawiki/core@master] Prepare to use JSON serialization for PageEditStash

https://gerrit.wikimedia.org/r/1165581

Change #1165592 merged by jenkins-bot:

[mediawiki/core@master] Make Content JsonCodecable

https://gerrit.wikimedia.org/r/1165592

Maintenance_bot removed a project: Patch-For-Review.Aug 20 2025, 9:31 PM

Change #1185190 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_43] Make Content JsonCodecable

https://gerrit.wikimedia.org/r/1185190

Change #1185191 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_44] Make Content JsonCodecable

https://gerrit.wikimedia.org/r/1185191

Change #1185191 merged by jenkins-bot:

[mediawiki/core@REL1_44] Make Content JsonCodecable

https://gerrit.wikimedia.org/r/1185191

Change #1185190 merged by jenkins-bot:

[mediawiki/core@REL1_43] Make Content JsonCodecable

https://gerrit.wikimedia.org/r/1185190

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2025, 5:32 PM