<bdo> should be converted to a ve.dm.LanguageAnnotation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 2 2020, 1:16 PM

Description

<bdo> is a bi-directional override tag, and is typically used with a dir and sometimes lang attribute. This the same as our ve.dm.LanguageAnnotation, except that defaults to just using a <span> tag.

Testing

Open https://en.wikipedia.org/wiki/User:ESanders_(WMF)/sandbox/nushu?veaction=edit
Try to edit the contents of the cell under "Your browser/device"
Observe the text is alienated (highlighted in green and blue stripes)

Expected

The text is editable (note it is likely you don't have the required font installed, so the text may appears as rectangles)

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (03532b74d)	mediawiki/extensions/VisualEditor	master	+3 -3
	Convert <bdo> tags to LanguageAnnotation	VisualEditor/VisualEditor	master	+8 -8

Customize query in gerrit

Related Objects

Mentioned Here: rGVED03532b74d17f: Convert <bdo> tags to LanguageAnnotation

Event Timeline

Esanders created this task.Oct 2 2020, 1:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2020, 1:16 PM

Change 631770 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Convert <bdo> tags to LanguageAnnotation

https://gerrit.wikimedia.org/r/631770

gerritbot added a project: Patch-For-Review.Oct 2 2020, 1:24 PM

Esanders claimed this task.Oct 2 2020, 1:24 PM

Esanders updated the task description. (Show Details)Oct 2 2020, 1:29 PM

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 631770 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Convert <bdo> tags to LanguageAnnotation

https://gerrit.wikimedia.org/r/631770

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2020, 6:10 PM

Change 631853 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (03532b74d)

https://gerrit.wikimedia.org/r/631853

gerritbot added a project: Patch-For-Review.Oct 2 2020, 7:29 PM

Change 631853 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (03532b74d)

https://gerrit.wikimedia.org/r/631853

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 2 2020, 8:55 PM

matmarex edited projects, added Skipped QA; removed Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 2 2020, 9:01 PM

Thank you for these testing instructions, Ed.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 3 2020, 1:37 AM

<bdo> should be converted to a ve.dm.LanguageAnnotationClosed, ResolvedPublicActions