Page MenuHomePhabricator

<bdo> should be converted to a ve.dm.LanguageAnnotation
Closed, ResolvedPublic

Description

<bdo> is a bi-directional override tag, and is typically used with a dir and sometimes lang attribute. This the same as our ve.dm.LanguageAnnotation, except that defaults to just using a <span> tag.

Testing

  1. Open https://en.wikipedia.org/wiki/User:ESanders_(WMF)/sandbox/nushu?veaction=edit
  2. Try to edit the contents of the cell under "Your browser/device"
  3. Observe the text is alienated (highlighted in green and blue stripes)

image.png (132×181 px, 5 KB)

Expected

  1. The text is editable (note it is likely you don't have the required font installed, so the text may appears as rectangles)

image.png (103×161 px, 4 KB)

Event Timeline

Change 631770 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Convert <bdo> tags to LanguageAnnotation

https://gerrit.wikimedia.org/r/631770

Change 631770 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Convert <bdo> tags to LanguageAnnotation

https://gerrit.wikimedia.org/r/631770

Change 631853 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (03532b74d)

https://gerrit.wikimedia.org/r/631853

Change 631853 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (03532b74d)

https://gerrit.wikimedia.org/r/631853

ppelberg added a subscriber: ppelberg.

Thank you for these testing instructions, Ed.