Media dialog shows nothing while loading
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 2 2020, 1:49 PM

Description

Double click on an image
Instantly the image selection becomes grey, but nothing else happens for a few hundred ms
Eventually the media dialog transitions in

This may be worse on slower connections/devices (you can test this by turning on network throttling)

Expected

The dialog shows instantly. Any info which is blocked on API requests can be shown later.

Details

	Subject	Repo	Branch	Lines +/-
	UploadBooklet: Don't show form until initialization completes	mediawiki/core	master	+12 -2
	Don't block media dialog on initialising upload booklet	mediawiki/extensions/VisualEditor	master	+13 -15

Customize query in gerrit

Related Objects

Mentioned In: T261969: TypeError: undefined is not an object (evaluating 'dialog.mediaUploadBooklet.setFile')

Event Timeline

Esanders created this task.Oct 2 2020, 1:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2020, 1:49 PM

Esanders updated the task description. (Show Details)Oct 2 2020, 5:05 PM

Change 631832 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't block media dialog on initialising upload booklet

https://gerrit.wikimedia.org/r/631832

gerritbot added a project: Patch-For-Review.Oct 2 2020, 5:29 PM

Change 631833 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] UploadBooklet: Don't show form until initialization completes

https://gerrit.wikimedia.org/r/631833

Esanders updated the task description. (Show Details)Oct 2 2020, 5:38 PM

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Esanders claimed this task.Oct 5 2020, 7:29 PM

Esanders moved this task from To Triage to Triaged on the VisualEditor board.Oct 6 2020, 10:31 PM

Change 631832 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't block media dialog on initialising upload booklet

https://gerrit.wikimedia.org/r/631832

Change 631833 merged by jenkins-bot:
[mediawiki/core@master] UploadBooklet: Don't show form until initialization completes

https://gerrit.wikimedia.org/r/631833

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 26 2020, 8:14 PM

matmarex edited projects, added Skipped QA; removed Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).Nov 26 2020, 9:00 PM

• ppelberg closed this task as Resolved.Dec 5 2020, 2:44 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 5 2020, 2:44 AM

Umherirrender mentioned this in T261969: TypeError: undefined is not an object (evaluating 'dialog.mediaUploadBooklet.setFile').Mar 4 2021, 12:02 AM

Media dialog shows nothing while loadingClosed, ResolvedPublicActions