Page MenuHomePhabricator

[SPIKE] How should non-DT comments be handled?
Open, Needs TriagePublic

Description

This task is about defining what approaches we could take to ensure the appropriate person/people are notified when someone is responding to them using full-page wikitext editing.

Background

Use Case 1/Event 1 requires that "Person A" be notified when "Person B" responds to something "Person A" has said, regardless of what editing interface "Person B" used to publish the response they've written.

Reply Tool comments
If "Person B" uses the Reply Tool to respond to "Person A's" comment, it is clear to the software who should be notified: the author of the comment comment to which the clicked [ reply ] link is appended.

Non-Reply Tool comments
If "Person B" uses full-page wikitext editing to respond to "Person A's" comment, it could be unclear to the software who should be notified.

Consider the following cases:

  • A) Person B responds to the authors of two separate comments [in the same section]. See T254263#6334962.
  • B) Person B incorrectly indents their comment such the software is not clear what the antecedent comment is (in the case below it is semantically Comment 1, but technically, it is not clear.
:::: Comment 1  [[User:Person A|Person A]] ([[User talk:Person A|talk]]) 12:11, 2 October 2020 (UTC)
:::: Comment 2  [[User:Person B|Person B]] ~~~~

Open questions

  • What heuristic does Echo currently use to send notification for comments posted with full-page wikitext editing? [i]
  • What other "Non-Reply Tool comment" cases should we be considering?
  • What can be done to increase the likelihood that notifications triggered by comments posted with full-page wikitext editing are sent to the "right" people [ii]? Read: lower the likelihood of notifications being sent to people they should not be sent to.

Approaches

Done

  • All "Open questions" are answered
  • "Approaches" are defined for how we can increase the likelihood that notifications triggered by comments posted with full-page wikitext editing are sent to the "right" people
  • An initial "Approach" is selected

i.

Event typeScreenshotURL
Comment posted on user's talk page
Screen Shot 2020-10-02 at 12.52.23 PM.png (192×1 px, 29 KB)
https://w.wiki/eqJ

ii. "Right people" in this context are defined as the author of a comment to which the respondent is replying to/addressing.

Event Timeline

What heuristic does Echo currently use to send notification for comments posted with full-page wikitext editing? [i]

You will get a ping for any:

  • Comment left on your talk page
  • Comment left anywhere which @-mentions you in the text, or the commit message.
  • Comment left anywhere which @-mentions you in the text, or the commit message.

The mention in wikitext works only if the message it’s included in is properly signed (this type of mention doesn’t actually require the @ sign, only that the expanded wikitext contains a link, so it may appear through a template or on its own). The pings in commit messages edit summaries work everywhere, both in talk and non-talk namespaces.

10-February team discussion outcomes(s)

  • Work on this ticket may NOT be necessary considering the way we're detecting new comments is tool-agnostic. As such, moving ti to the backlog.