| ABorbaWMF | |
| Oct 2 2020, 8:56 PM |
| F35870171: image.png | |
| Dec 16 2022, 1:56 PM |
| F35870169: image.png | |
| Dec 16 2022, 1:56 PM |
| F35561336: Screenshot_20221010-130138.png | |
| Oct 10 2022, 8:11 PM |
| F35561333: unnamed.png | |
| Oct 10 2022, 8:11 PM |
| F32371642: image0.png | |
| Oct 2 2020, 8:56 PM |
Certain articles have lists with alternating colors, which breaks the theming logic in dark and black themes.
A few examples:
https://en.wikipedia.org/wiki/Changes_(Charles_Bradley_album)
https://en.wikipedia.org/wiki/Renewal_(Billy_Strings_album)
https://en.wikipedia.org/wiki/2021_Australian_Open_%E2%80%93_Men%27s_singles
https://en.wikipedia.org/wiki/Staten_Island#Government_and_politics
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T252904 Issues with dark mode / non-white reading themes | |||
| Resolved | Jgiannelos | T264474 Tables with alternating colors appear incorrectly in dark theme. |
Here's another example on English Wikipedia, a table produced by the "Track listing" template on https://en.wikipedia.org/wiki/Renewal_(Billy_Strings_album)
In this case, the table rows alternate between white and light gray background to facilitate readability. (Many tables on Wikipedia use this pattern.) The ones with white backgrounds are readable, but the ones with light gray backgrounds are not because the text color still gets turned to white when using a dark theme.
iPad:
Android phone:
Okay, it's been over two years and the solution is to simply change the color value of the background. Why hasn't anyone taken the five seconds to do so? Can someone give me the authorization to do it? It'd be a lot faster than sitting here adding more reports endlessly.
Change 861403 had a related patch set uploaded (by KarlBeecken; author: KarlBeecken):
[mediawiki/services/mobileapps@master] dirtyfix mobile zebra table dark mode issue
Change 861403 abandoned by KarlBeecken:
[mediawiki/services/mobileapps@master] dirtyfix mobile zebra table dark mode issue
Reason:
Change 861406 had a related patch set uploaded (by KarlBeecken; author: KarlBeecken):
[mediawiki/services/mobileapps@master] dirtyfix mobile zebra table dark mode issue
Change 861406 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] dirtyfix mobile zebra table dark mode issue
Merged and deployed, may still show up as broken in cached content until the cache expires.
I tested this on the example from above, the track listing table from https://en.wikipedia.org/wiki/Renewal_(Billy_Strings_album), but it isn't fixed even after purging the cache, making a null edit, or previewing the table with a non-null edit.
I believe the CSS is still cached on the server side, and that's what needs to expire first.
I updated the description of this task to be specifically regarding the issue with alternating colors, which was fixed by @KarlBeecken. Other instances of incorrect table backgrounds will still exist, and can be tracked via T284327.
Cache has been purged, so clients should now be getting the updated CSS. Client-side cache might still take up to a day to refresh, but this should be fixed now.
I verified it using this URL: https://en.wikipedia.org/api/rest_v1/page/mobile-html/Renewal_(Billy_Strings_album)?theme=dark
It looks like the table is rendered properly now
@SunAfterRain That was a slightly different issue. It looks like that particular table template has CSS that sets an explicit background color on the tr::before selector. Upon editing that template to exclude our theme, the issue disappears.