Page MenuHomePhabricator

Implement undo for the instant "Rotate video"
Closed, ResolvedPublic

Description

On tapping "Undo" beside "Rotate video" the player has to set to a normal position if it is in a rotated position.

Event Timeline

Aklapper renamed this task from Implement undo for the instatnt "Rotate video" to Implement undo for the instant "Rotate video".Oct 3 2020, 4:34 PM
Gopavasanth added a parent task: Restricted Task.Oct 5 2020, 5:16 AM
Gopavasanth edited parent tasks, added: T252320: Improve video cropping + rotating experience.; removed: Restricted Task.

Hey @Gopavasanth
I am Working in this can you tell me which function is used for rotate video.
The code is so long i am get confused. From where to start or can u guide me for it how to approach this

@Bharatkhatri351: Have you tried searching the codebases for the string otateVideo? :)

Hey @Gopavasanth
I Have submitted the Patch please check this out

Change 654829 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[labs/tools/VideoCutTool@master] Implement undo for the instant Rotate Video

https://gerrit.wikimedia.org/r/654829

Hi @Bharatkhatri351 Thanks for your patch, I had a look at your patch, seems like its a good idea but unfortunately, we need to wait for T252320 before merging this one :)

Hello @Gopavasanth
as this patch is merged now u can review my patch now...
i have noticed this bug is still exist in videocuttool

Hi @Bharatkhatri351 Thanks for your patch, I had a look at your patch, seems like its a good idea but unfortunately, we need to wait for T252320 before merging this one :)

Change 654829 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Implement undo for the instant Rotate Video

https://gerrit.wikimedia.org/r/654829