Page MenuHomePhabricator

Don't add nowiki tags in visual mode (or allow opting out)
Closed, ResolvedPublic

Description

As a user,
When I try to reply to a comment,
And I use the visual mode so I can more easily ping a user, or because it is the default
and I use template markup to use {{done}}

Expected result:
{{done}} is included in the edit saved

Actual result:
<nowiki>{{done}}</nowiki> is included

Since the visual editor doesn't currently allow including templates, I have to either remember to switch to the source editor, or fix my edit after it saves

Event Timeline

Restricted Application added subscribers: jeblad, Aklapper. · View Herald Transcript

If we didn't add nowiki tags in visual mode, then it would no longer be visual.

I think what you really want is either (or both) a toolbar button or autocompletion for pings in wikitext mode, or being able to add templates normally in visual mode.

JTannerWMF added subscribers: ppelberg, JTannerWMF.

@ppelberg will find the related template task and merge it into this one as a duplicate then close this task. The template task is blocked on the RFC.

@ppelberg will find the related template task and merge it into this one as a duplicate then close this task. The template task is blocked on the RFC.

Any updates?

@ppelberg will find the related template task and merge it into this one as a duplicate then close this task. The template task is blocked on the RFC.

Any updates?

I'm sorry for the long lag on this, @DannyS712.

As @JTannerWMF and @matmarex alluded to in the comments above, there seem to be two potential fixes for the issue this ticket represents. [i] These fixes, and their associated tickets, are below.

  • Add support extensions and templates within indented comments: T251633
  • Make it easier for people using DiscussionTools' source mode to ping someone: T257391 [ii]

i. Please re-open this task if you do not think the tickets linked above will resolve the root issue(s) you are reporting in this task.
ii. I've added your name to the task description where we are accumulating evidence of demand for this task.

@ppelberg will find the related template task and merge it into this one as a duplicate then close this task. The template task is blocked on the RFC.

Any updates?

I'm sorry for the long lag on this, @DannyS712.

As @JTannerWMF and @matmarex alluded to in the comments above, there seem to be two potential fixes for the issue this ticket represents. [i] These fixes, and their associated tickets, are below.

  • Add support extensions and templates within indented comments: T251633
  • Make it easier for people using DiscussionTools' source mode to ping someone: T257391 [ii]

i. Please re-open this task if you do not think the tickets linked above will resolve the root issue(s) you are reporting in this task.
ii. I've added your name to the task description where we are accumulating evidence of demand for this task.

T251633 appears to be about multiline comments being indented on subsequent lines - I want to be able to reply, eg, @User {{done}} --~~~~ on a single line in visual mode, so I don't think this is a duplicate

T251633 appears to be about multiline comments being indented on subsequent lines - I want to be able to reply, eg, @User {{done}} --~~~~ on a single line in visual mode, so I don't think this is a duplicate

@DannyS712, we saw the comment you left [i] on Wikipedia talk: Talk pages project#Experiences about this ticket.

A resulting question for you: would it be accurate for me to understand you as requesting a way to be able to insert a template using the Reply Tool's visual mode?


i. https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Talk_pages_project&type=revision&diff=1005664593&oldid=1005664079&diffmode=source

ppelberg assigned this task to DannyS712.

hey @DannyS712, I'm assigning this task over to you to answer the question I posed in T264520#6831297.

...I'm wanting to make sure we're accurately understanding this issue you raised in this conversation: https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project#Experiences.

hey @DannyS712, I'm assigning this task over to you to answer the question I posed in T264520#6831297.

...I'm wanting to make sure we're accurately understanding this issue you raised in this conversation: https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project#Experiences.

Sorry, I didn't see your question earlier

T251633 appears to be about multiline comments being indented on subsequent lines - I want to be able to reply, eg, @User {{done}} --~~~~ on a single line in visual mode, so I don't think this is a duplicate

@DannyS712, we saw the comment you left [i] on Wikipedia talk: Talk pages project#Experiences about this ticket.

A resulting question for you: would it be accurate for me to understand you as requesting a way to be able to insert a template using the Reply Tool's visual mode?


i. https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Talk_pages_project&type=revision&diff=1005664593&oldid=1005664079&diffmode=source

Basically, yes - T251633 is about indentation for multiple line comments, and my use case was for a single-line comment

T251633 appears to be about multiline comments being indented on subsequent lines - I want to be able to reply, eg, @User {{done}} --~~~~ on a single line in visual mode, so I don't think this is a duplicate

@DannyS712, we saw the comment you left [i] on Wikipedia talk: Talk pages project#Experiences about this ticket.

A resulting question for you: would it be accurate for me to understand you as requesting a way to be able to insert a template using the Reply Tool's visual mode?


i. https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Talk_pages_project&type=revision&diff=1005664593&oldid=1005664079&diffmode=source

Basically, yes - T251633 is about indentation for multiple line comments, and my use case was for a single-line comment

Understood. I think T251633 will cover the use case you were describing [i], considering its scope includes adding support for all extensions and templates.

To be doubly sure the functionality you are describing does not get lost, I've added an action item [ii] for us to check in with you before closing T251633.

And with the above, I'm going to resolve this ticket.


i. Adding support for a single-line template like {{done}}.
ii. See T251633's ===Done section