Page MenuHomePhabricator
Create Task
Maniphest T264594

Remove term migration settings from DataAccessSettings
Closed, ResolvedPublic
Actions

Description

The getters will still be there, but return hard-coded true, to make it more obvious that other places in the code can stop calling those getters.

Details

SubjectRepoBranchLines +/-
Remove normalized terms settings from DataAccessSettingsmediawiki/extensions/Wikibasemaster+22 -114
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 5 2020, 10:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2020, 10:50 AM
gerritbot added a comment.Oct 5 2020, 11:01 AM

Change 632213 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove normalized terms settings from DataAccessSettings

https://gerrit.wikimedia.org/r/632213

gerritbot added a project: Patch-For-Review.Oct 5 2020, 11:01 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase wb_terms leftovers 2020 board.Oct 5 2020, 11:04 AM
gerritbot added a comment.Oct 5 2020, 3:24 PM

Change 632213 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove normalized terms settings from DataAccessSettings

https://gerrit.wikimedia.org/r/632213

• toan moved this task from Peer Review to Verification on the Wikibase wb_terms leftovers 2020 board.Oct 5 2020, 3:33 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED).Oct 5 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 5 2020, 4:10 PM
Addshore moved this task from Verification to Done on the Wikibase wb_terms leftovers 2020 board.Oct 6 2020, 8:11 AM
Addshore closed this task as Resolved.Oct 6 2020, 8:11 AM
Lucas_Werkmeister_WMDE mentioned this in T264724: Remove term migration getters from DataAccessSettings.Oct 6 2020, 9:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL