Page MenuHomePhabricator

Remove “terms table search fields” settings from DataAccessSettings
Closed, ResolvedPublic


These settings used to control whether Wikibase reads and writes the wb_terms.term_search_key. Without wb_terms table, there’s no reason to keep these settings.

Event Timeline

It turns out we don’t read those settings from DataAccessSettings anyways – where needed, we instead directly get them from the underlying settings, for example:

$termSqlIndex->setUseSearchFields( $settings->getSetting( 'useTermsTableSearchFields' ) );

So I guess the DataAccessSettings part can be removed at any time. (Removing the rest of the settings is a separate task, T264597.)

Change 632450 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove search settings from DataAccessSettings

Change 632450 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove search settings from DataAccessSettings