| Paladox | |
| Oct 5 2020, 11:08 PM |
| F32381037: Screenshot 2020-10-11 at 00.15.22.png | |
| Oct 10 2020, 11:17 PM |
| F32381035: Screenshot 2020-10-11 at 00.14.49.png | |
| Oct 10 2020, 11:17 PM |
| F32381039: Screenshot 2020-10-11 at 00.16.02.png | |
| Oct 10 2020, 11:17 PM |
See T254302#6519686
When having DismissionSiteNotice installed and using SiteNoticeAfter hook on MobileFrontend (not mutually exclusive to this extension), it causes the text to wrap and the box size is smaller.
See below:
^ it's not so much an issue on desktop, but when using it on mobile, that's when the issue starts to be noticed.
Should look like:
It's even a problem on timeless too. So removing the margin would be a benefit.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix text being wrapped under mobile | mediawiki/extensions/DismissableSiteNotice | master | +2 -6 |
Change 632335 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/DismissableSiteNotice@master] Set margin to 0
Can you expand the task description to describe the problem statement with some screenshots (for multiple skins)? Thanks in advance!
thanks for demonstrating the before and after. How would this margin change impact Vector? Could you do the same for that skin?
Change 632335 abandoned by Jdlrobson:
[mediawiki/extensions/DismissableSiteNotice@master] Fix text being wrapped under mobile
Reason:
Change 632335 restored by Jdlrobson:
[mediawiki/extensions/DismissableSiteNotice@master] Fix text being wrapped under mobile