Page MenuHomePhabricator

DismissionSiteNotice causes site notice to get wrapped
Open, Needs TriagePublic


See T254302#6519686

When having DismissionSiteNotice installed and using SiteNoticeAfter hook on MobileFrontend (not mutually exclusive to this extension), it causes the text to wrap and the box size is smaller.

See below:

Screenshot 2020-10-11 at 00.14.49.png (1×3 px, 330 KB)

^ it's not so much an issue on desktop, but when using it on mobile, that's when the issue starts to be noticed.

Screenshot 2020-10-11 at 00.15.22.png (2×1 px, 689 KB)

Should look like:

Screenshot 2020-10-11 at 00.16.02.png (2×1 px, 686 KB)

It's even a problem on timeless too. So removing the margin would be a benefit.

Event Timeline

Change 632335 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/DismissableSiteNotice@master] Set margin to 0

Can you expand the task description to describe the problem statement with some screenshots (for multiple skins)? Thanks in advance!

Paladox renamed this task from Using SitenoticeAfter hook, causes this extension to wrap the notice to DismissionSiteNotice causes site notice to get wrapped.Oct 10 2020, 11:17 PM
Paladox updated the task description. (Show Details)

@Jdlrobson updated description.

thanks for demonstrating the before and after. How would this margin change impact Vector? Could you do the same for that skin?

Change 632335 abandoned by Jdlrobson:
[mediawiki/extensions/DismissableSiteNotice@master] Fix text being wrapped under mobile


Change 632335 restored by Jdlrobson:
[mediawiki/extensions/DismissableSiteNotice@master] Fix text being wrapped under mobile