Page MenuHomePhabricator

Make config change to enable Reply Tool as Beta Feature at Phase 2 wikis
Closed, ResolvedPublic

Description

This task is about enabling the relevant config flag(s) to make The Reply Tool available to contributors at the "Phase 2" wikis (listed below) as a Beta Feature.

Phase 2 wikis

Source: Talk pages project/Scaling

Column AColumn BColumn CColumn DColumn E
Wikipedia (unless otherwise noted)Language codeAnnouncement URLPages to test whether [ reply ] links appearPages where you can test posting comments
AmharicamSee Column H (Communication Channel in the Talk pages project/Scaling sheet.Copy contents from pages linked in this table's Column D to your sandbox
Assameseas" "" "
Bhojpuribh" "" "
*Spanishes" "" "
Basqueeu" "" "
Persianfa" "" "
Finnish See: T264693#6541327fi
*Hebrewhe" "" "
*Hindihi" "" "
Armenianhy" "" "
Icelandicis" "" "
*Italianit" "" "
*Lithuanianlt" "" "
Maithilimai" "" "
Mttonmnw" "" "
Marathimr" "" "
*Burmesemy" "" "
Nepaline" "" "
Norwegian Bokmalno" "" "
N'Konqo" "" "
Punjabipa" "" "
Polishpl" "" "
*Portuguesept" "" "
*Santalisat" "" "
Sinhalasi" "" "
Tamilta" "" "
*Thaith" "" "
*Turkishtr" "" "
Ukrainianuk" "" "
*Meta-Wikimetawiki" "" "
English Wikiversityen.wikiversity" "" "

* = Wikis we should prioritize testing the Reply Tool on.

Implementation details

  • To use the Reply Tool, all logged in editors at the Wikipedias listed in the "Phase 2 wikis" section above, who DO NOT have the Automatically enable most beta features preference enabled, will need to do the following:
  • To use the Reply Tool, all logged in editors at the Wikipedias listed in the "Phase 2 wikis" section above, who DO have the Automatically enable most beta features preference enabled, will need to do the following:
    • 1. Visit any talk page or talk-like page (e.g. a page where __NEWSECTIONLINK__ is present), observe [ reply ] links are appended to each comment

Deployment timing

Wednesday, 14-October assuming no blocking issues are identified as part of T264692.

Testing instructions

  1. Visit Special:Preferences > Beta features (read: mw-prefsection-betafeatures) at each of the Wikipedias listed above and confirm DiscussionTools is available as a Beta feature
  2. Visit the pages listed in the "Pages to test whether [ reply ] links appear" column above and file a task if [ reply ] links are NOT appearing where and/or how they should be
  3. Visit the pages listed in the "Pages where you can test posting comments" column above and:
    • A) Document the text input mode – source or visual – is shown when a logged in user uses the Reply Tool for the first time on a given wiki
    • B) Document if the Reply Tool does NOT "remember" [i] the text input mode – source or visual – you used in your previous edit
    • C) File a task if you encounter cases where you are unable to post comments [ii] and/or if the Reply Tool behaves in any ways you deem to be unexpected

Text input mode behavior

WikiInput mode shown by default (logged in)Tool remembers last input mode used (y/n)

This information can be found in the T264693 sheet of this workbook: Reply Tool QA.

Done

  • The behavior described in the "Implementation" details section above is implemented
  • QA has completed the steps described in the "Testing instructions" section
  • QA has filed tickets for the new issues that surfaced while completing the steps described in the "Testing instructions" section
  • QA has filled in the table in the "Text input mode behavior" section

Event Timeline

ppelberg created this task.Tue, Oct 6, 12:54 AM
ppelberg updated the task description. (Show Details)Tue, Oct 6, 12:57 AM
ppelberg added a comment.EditedThu, Oct 8, 10:58 PM

Deployment timing
Per the conversation @Whatamidoing-WMF and I had today, the Reply Tool should be made available at the "Phase 2 wikis" [i] listed in the task description on Wednesday, 14-October assuming no blocking issues are identified as part of T264692.


i. The "Phase 2 wikis" section will be populated by EOD tomorrow, 9-October-2020.

ppelberg updated the task description. (Show Details)Thu, Oct 8, 10:59 PM
ppelberg updated the task description. (Show Details)Fri, Oct 9, 7:52 PM
Restricted Application added subscribers: Huji, jeblad, jhsoby, Base. · View Herald TranscriptFri, Oct 9, 7:52 PM
ppelberg updated the task description. (Show Details)Fri, Oct 9, 7:53 PM

i. The "Phase 2 wikis" section will be populated by EOD tomorrow, 9-October-2020.

The "Phase 2 wikis" section is now completed.

Peter, I missed Santali earlier. I've just added it to the task description.

@ppelberg: Please let @matmarex know whether we can put English Wikiversity in this group as well. I'd rather have it go up as a Beta Feature than as a sitewide script.

Change 633568 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[operations/mediawiki-config@master] Enable DiscussionTools as a beta feature on 30 more wikis ("phase 2")

https://gerrit.wikimedia.org/r/633568

(I can update the patch if the list changes – right now it matches the task description, including Santali Wikipedia and excluding English Wikiversity)

Scheduled for Wednesday: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20201014T1100

ppelberg updated the task description. (Show Details)EditedWed, Oct 14, 4:51 AM

English Wikiversity

@ppelberg: Please let @matmarex know whether we can put English Wikiversity in this group as well. I'd rather have it go up as a Beta Feature than as a sitewide script.

@Whatamidoing-WMF: enabling the Reply Tool as a Beta Feature at the English Wikiversity sounds good. I've added en.wikiversity to the table in the task description's "Phase 2 wikis" section.

ppelberg added a comment.EditedWed, Oct 14, 5:09 AM

Finish Wikipedia
Decision
The Reply Tool should NOT be deployed to the Finnish Wikipedia tomorrow. Instead, it should be deployed to the Finnish Wikipedia next Tuesday, 20-October. Here is a task for that deployment: T265446.

This decision and the newly-filed task have been added to this task's description.

Rationale
We are delaying the Reply Tool's deployment to the Finnish Wikipedia for one week in order to better understand the origins of the policy that prompted T265291 to be filed and to create some space for the Finnish Wikipedia to discuss the policy itself further.

ppelberg updated the task description. (Show Details)Wed, Oct 14, 5:18 AM

(updated the patch: +English Wikiversity, −Finnish Wikipedia)

Change 633568 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable DiscussionTools as a beta feature on 30 more wikis ("phase 2")

https://gerrit.wikimedia.org/r/633568

Mentioned in SAL (#wikimedia-operations) [2020-10-14T11:22:16Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: c63632de6a20b2f00da91187e5cf416fd39d8c5b: Enable DiscussionTools as a beta feature on 30 more wikis (T264693) (duration: 01m 15s)

ppelberg moved this task from Inbox to High Priority on the Editing QA board.
ppelberg updated the task description. (Show Details)Wed, Oct 14, 3:46 PM

Testing

@Ryasmeen I've added the following columns to the table within the task description's "Phase 2 wikis" section

  • Pages to test whether [ reply ] links appear
  • Pages where you can test posting comments

For now, can you start by testing from the wikis at the top of the table and moving downwards (read: Assamese > Assamese > etc.)?

On maiwiki, mnwwiki, newiki, thwiki the reply links are not showing up – this is reported as T265500 and should be fixed tomorrow.

ppelberg updated the task description. (Show Details)Wed, Oct 14, 9:33 PM
ppelberg updated the task description. (Show Details)Wed, Oct 14, 10:53 PM

For now, can you start by testing from the wikis at the top of the table and moving downwards (read: Assamese > Assamese > etc.)?

@Ryasmeen: so you're aware, to communicate the wikis we should prioritize testing on, I've added an * to the applicable rows within Column A of the table in the task description's "Phase 2 wikis" section.

On maiwiki, mnwwiki, newiki, thwiki the reply links are not showing up – this is reported as T265500 and should be fixed tomorrow.

Noted. Thank you for the heads up, @matmarex.

ppelberg reassigned this task from matmarex to Ryasmeen.Thu, Oct 15, 3:11 AM
Ryasmeen added a comment.EditedThu, Oct 15, 9:12 PM

Completed testing on the following wikis:

Amharic, Assamese, Bhojpuri, *Spanish, *Hebrew, *Hindi, *Italian, *Lithuanian, *Burmese, *Portuguese, *Santali, *Thai, *Turkish and *Meta-Wiki.

Details of the test results can be found here:
https://docs.google.com/spreadsheets/d/1ccTSx-v1yb8kvli7e8djFexXL7jThPHE1WomtkCLG6I/edit#gid=52183578

Two observations:

  1. For Spanish wiki, when a logged in user uses the Reply Tool for the first time the source mode is shown for the Reply tool. And that was the only one that showed this mode. Wanted to confirm if that's expected.
  1. There are some comments which had Reply links missing. I am assuming that's because they don't have a signature that contains a link to a user or talk page or they are newsletters. Or is it because the timestamp is appearing on a new line? @matmarex: Can you confirm this behavior?

Here are some screenshots showing such cases:

Page: https://bh.wikipedia.org/wiki/%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF%E0%A4%AA%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE:%E0%A4%9A%E0%A5%8C%E0%A4%AA%E0%A4%BE%E0%A4%B2

  1. For Spanish wiki, when a logged in user uses the Reply Tool for the first time the source mode is shown for the Reply tool. And that was the only one that showed this mode. Wanted to confirm if that's expected.

I'm glad you're asking to confirm this, Rummana. It is expected that logged in users who have not yet made any edits are shown the Reply Tool's source mode when using it for the first time.

We decided this behavior in T250523. Specifically this row of the Text input mode configuration table:

Account statusWiki configurationUser's editing mode preferenceUser edit countReply text input defaultNotes
Logged intwo edit tabsno preference set0follow behavior defined in getPreferredEditorThis means visual on all wikis except: en.wikipedia, es.wikipedia, he.wikipedia and fr.wikitionary
  1. There are some comments which had Reply links missing. I am assuming that's because they don't have a signature that contains a link to a user or talk page or they are newsletters. Or is it because the timestamp is appearing on a new line? @matmarex: Can you confirm this behavior?

Here are some screenshots showing such cases:

Page: https://bh.wikipedia.org/wiki/%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF%E0%A4%AA%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE:%E0%A4%9A%E0%A5%8C%E0%A4%AA%E0%A4%BE%E0%A4%B2

Yes, I think this is as expected.

In case 1, the signature and the timestamp and on separate lines, so they are recognized as a comment.

In case 2, the link points to a page on another wiki, rather than a local user or user talk page.

Ryasmeen edited projects, added Verified; removed Editing QA.Thu, Oct 22, 2:42 AM
ppelberg closed this task as Resolved.Sat, Oct 24, 12:57 AM
ppelberg updated the task description. (Show Details)
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSat, Oct 24, 12:57 AM