The module ext.uls.compactlinks and its associated beta feature should be disabled on new Vector
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 7 2020, 12:05 AM

Description

Universal Language Selector limits the list of languages to 10 and adds a button underneath that launches Universal Language Selector. This will cause problems for us as we move the language button position, so we will need a mechanism for disabling the loading of this module for modern Vector.

Screen Shot 2020-10-06 at 5.02.02 PM.png (592×390 px, 45 KB)

We will wire up a modified version of this code for Vector which simply renders the button.

Acceptance criteria

The code for the click handler for the language button is factored out into a lightweight module.
The UniversalLanguageSelector hook will need to check the Vector skin version and not load ext.uls.compactlinks if modern Vector is enabled.
When modern Vector is enabled a new module will be loaded that enhances the button being created in T260738 with the new factored out click handler
The new module should be tiny (<1kb)

QA steps

Enable "Use a compact language list, with languages relevant to you." on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rendering and visit https://en.wikipedia.beta.wmflabs.org/wiki/Limbourg_brothers. Check the button there works.

QA Results - Beta

AC	Status	Details
1	✅	T264824#6648675

QA Results - Prod

AC	Status	Details
1	✅	T264824#6672056

Details

Subject	Repo	Branch	Lines +/-
Compact language links module is loaded via server side	mediawiki/extensions/UniversalLanguageSelector	master	+11 -20
Allow skins to register their own button and disable compact	mediawiki/extensions/UniversalLanguageSelector	master	+63 -38
Separate compacting of language list from launching of dialog	mediawiki/extensions/UniversalLanguageSelector	master	+177 -126
Compact personal links can be wired up to an existing button	mediawiki/extensions/UniversalLanguageSelector	master	+63 -30

Customize query in gerrit

Related Objects

Mentioned Here: T260738: Language button v1 - allow language button to appear at top of page (plus JS fallback)

Event Timeline

Jdlrobson created this task.Oct 7 2020, 12:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2020, 12:05 AM

Jdlrobson updated the task description. (Show Details)Oct 7 2020, 12:06 AM

Nikerabbit subscribed.Oct 12 2020, 2:20 PM

Change 635081 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] Compact personal links can be wired up to an existing button

https://gerrit.wikimedia.org/r/635081

gerritbot added a project: Patch-For-Review.Oct 19 2020, 9:04 PM

Jdlrobson assigned this task to ovasileva.Oct 20 2020, 8:55 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

Adding to sprint board for visibility that im working on this with langeng

Jdlrobson moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Oct 21 2020, 10:32 PM

Change 635677 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] WIP: Separate compacting of language list from launching of dialog

https://gerrit.wikimedia.org/r/635677

Change 635080 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] POC: Language button prototype

https://gerrit.wikimedia.org/r/635080

Change 635679 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] Allow skins to register their own button and disable compact

https://gerrit.wikimedia.org/r/635679

Change 635081 abandoned by Jdlrobson:
[mediawiki/extensions/UniversalLanguageSelector@master] Compact personal links can be wired up to an existing button

Reason:
The approach in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/ /635677 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/ /635679 is superior.

https://gerrit.wikimedia.org/r/635081

Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Oct 22 2020, 6:28 PM

ovasileva triaged this task as High priority.Oct 27 2020, 6:11 PM

(mostly for my own benefit)
2 patches remain:

Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Nov 2 2020, 6:17 PM

Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Nov 2 2020, 11:28 PM

Change 635677 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Separate compacting of language list from launching of dialog

https://gerrit.wikimedia.org/r/635677

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Nov 5 2020, 9:00 AM

I've just rebased the last remaining patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/635679

Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Nov 16 2020, 6:35 PM

Change 641220 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/UniversalLanguageSelector@master] Compact language links module is loaded via server side

https://gerrit.wikimedia.org/r/641220

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Nov 16 2020, 7:08 PM

Test wiki created on Patch Demo by AHollender (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/c690c3fd3666b29441fa54d236b73c28/w/

Change 635679 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Allow skins to register their own button and disable compact

https://gerrit.wikimedia.org/r/635679

Change 641220 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Compact language links module is loaded via server side

https://gerrit.wikimedia.org/r/641220

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Nov 18 2020, 5:11 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.20; 2020-12-01); removed MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Nov 18 2020, 6:00 PM

Jdlrobson updated the task description. (Show Details)Nov 18 2020, 6:07 PM

Test wiki created on Patch Demo by Jdlrobson using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/c4f44d854e5f8c924f540a4a693d9645/w/

Test wiki created on Patch Demo by Jdlrobson using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/f8efae4a8ea58c79d6a05716821f03a5/w/

Test wiki created on Patch Demo by Jdlrobson using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/222fef60dc05cd927e380e9a8aaf00dc/w/

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Enable "Use a compact language list, with languages relevant to you." on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rendering and visit the main page.
❌ AC1: Check the button there works.
No button is visible.

Screen Shot 2020-11-20 at 9.21.05 PM.png (1×1 px, 543 KB)

Edtadros updated the task description. (Show Details)Nov 21 2020, 5:24 AM

I can reproduce this but have no idea why it's happening. @Nikerabbit do you have any ideas why this check might be failing on the beta cluster main page?
I can't reproduce locally, so I'm guessing the logic for noexternallanglinks might be to blame here but I don't want to assume. mw-interlanguage-selector does not appear in the page HTML and I'd assume that isCompactLinksEnabled always passes when the preference is set.

$excludedLinks = $out->getProperty( 'noexternallanglinks' );
$override = is_array( $excludedLinks ) && in_array( '*', $excludedLinks );
if ( !$override && self::isCompactLinksEnabled( $out->getUser() ) && strpos( $out->getHTML(), 'mw-interlanguage-selector' ) === false ) {

I'm sure the main page is excluded due to noexternallanglinks (similar to production enwiki main page). You can see {{noexternallanglinks}} near the bottom of the page source.

I suggest testing on some other page such as https://en.wikipedia.beta.wmflabs.org/wiki/Limbourg_brothers (picked from https://en.wikipedia.beta.wmflabs.org/wiki/Special:MostInterwikis).

Thanks @Nikerabbit for explaining!

@Edtadros I've updated the QA steps accordingly. Apparently, the main page is working as expected.

ovasileva reassigned this task from Jdlrobson to Edtadros.Nov 25 2020, 9:07 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Enable "Use a compact language list, with languages relevant to you." on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rendering
Visit https://en.wikipedia.beta.wmflabs.org/wiki/Limbourg_brothers.
✅ AC1: Check the button there works.

Screen Recording 2020-11-25 at 6.34.28 AM.mov.gif (1×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Nov 25 2020, 2:36 PM

Edtadros updated the task description. (Show Details)

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Test Result - PROD

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Enable "Use a compact language list, with languages relevant to you." on https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering
Visit https://en.wikipedia.org/wiki/Limbourg_brothers.
✅ AC1: Check the button there works.

Screen Recording 2020-12-06 at 10.09.57 AM.mov.gif (1×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Dec 6 2020, 6:14 PM

All done!

Test wiki on Patch Demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/222fef60dc05cd927e380e9a8aaf00dc/w/~~

Test wiki on Patch Demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/f8efae4a8ea58c79d6a05716821f03a5/w/~~

Test wiki on Patch Demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/c4f44d854e5f8c924f540a4a693d9645/w/~~

Test wiki on Patch Demo by AHollender (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/c690c3fd3666b29441fa54d236b73c28/w/~~

	F33937616: Screen Recording 2020-12-06 at 10.09.57 AM.mov.gif
	Dec 6 2020, 6:13 PM

	F33924975: Screen Recording 2020-11-25 at 6.34.28 AM.mov.gif
	Nov 25 2020, 2:35 PM

	F33920977: Screen Shot 2020-11-20 at 9.21.05 PM.png
	Nov 21 2020, 5:23 AM

	F32376253: Screen Shot 2020-10-06 at 5.02.02 PM.png
	Oct 7 2020, 12:05 AM

The module ext.uls.compactlinks and its associated beta feature should be disabled on new VectorClosed, ResolvedPublicActions

Description

Acceptance criteria

QA steps

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Beta

QA Steps

Test Result - PROD

QA Steps

The module ext.uls.compactlinks and its associated beta feature should be disabled on new Vector
Closed, ResolvedPublic
Actions