Page MenuHomePhabricator

Add an option to disable GuidedTour for Special:GlobalWatchlistSettings
Closed, ResolvedPublic4 Estimated Story Points

Description

Per T260860#6523811 and discussion on this task

Event Timeline

DannyS712 created this task.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

@Krinkle would it be okay to instead hide this behind $wgGlobalWatchlistEnableGuidedTour with a default of false, so that if the tour can be restored in the future everything is already there, rather than removing everything entirely?

@Krinkle would it be okay to instead hide this behind $wgGlobalWatchlistEnableGuidedTour with a default of false, so that if the tour can be restored in the future everything is already there, rather than removing everything entirely?

I think that would be fine, as long as that variable wouldn't be set to true in WMF production (perhaps CS.php forcing it to be false?).

@Krinkle would it be okay to instead hide this behind $wgGlobalWatchlistEnableGuidedTour with a default of false, so that if the tour can be restored in the future everything is already there, rather than removing everything entirely?

I think that would be fine, as long as that variable wouldn't be set to true in WMF production (perhaps CS.php forcing it to be false?).

Sure, just in case the default is ever changed

DannyS712 renamed this task from Remove GuidedTour for Special:GlobalWatchlistSettings to Add an option to disable GuidedTour for Special:GlobalWatchlistSettings.Oct 8 2020, 6:49 PM
DannyS712 updated the task description. (Show Details)

Change 632990 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Add $wgGlobalWatchlistEnableGuidedTour

https://gerrit.wikimedia.org/r/632990

DannyS712 set the point value for this task to 4.
DannyS712 added subscribers: Niharika, ashley.

Tested on patch demo, the patch above works. Since this is blocking the security review, I'd appreciate it if the patch could be reviewed as soon as possible - @Niharika @ashley can you take a look?

Change 632990 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Add $wgGlobalWatchlistEnableGuidedTour

https://gerrit.wikimedia.org/r/632990