Add an option to disable GuidedTour for Special:GlobalWatchlistSettings
Closed, ResolvedPublic4 Estimated Story Points
Actions

Assigned To

Authored By

	DannyS712
	Oct 7 2020, 3:28 AM

Description

Per T260860#6523811 and discussion on this task

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add $wgGlobalWatchlistEnableGuidedTour	mediawiki/extensions/GlobalWatchlist	master	+261 -128

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	DannyS712	T260862 Deploy GlobalWatchlist extension to production (Meta only)
Resolved	• Gilles	T260860 Performance review of GlobalWatchlist
Resolved	DannyS712	T264833 Add an option to disable GuidedTour for Special:GlobalWatchlistSettings

Event Timeline

DannyS712 created this task.Oct 7 2020, 3:28 AM

DannyS712 triaged this task as High priority.

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

DannyS712 mentioned this in T260860: Performance review of GlobalWatchlist.

@Krinkle would it be okay to instead hide this behind $wgGlobalWatchlistEnableGuidedTour with a default of false, so that if the tour can be restored in the future everything is already there, rather than removing everything entirely?

sbassett mentioned this in T260466: Security Readiness Review For GlobalWatchlist extension.Oct 8 2020, 4:37 PM

In T264833#6527469, @DannyS712 wrote:

@Krinkle would it be okay to instead hide this behind $wgGlobalWatchlistEnableGuidedTour with a default of false, so that if the tour can be restored in the future everything is already there, rather than removing everything entirely?

I think that would be fine, as long as that variable wouldn't be set to true in WMF production (perhaps CS.php forcing it to be false?).

In T264833#6529912, @Urbanecm wrote:

In T264833#6527469, @DannyS712 wrote:

@Krinkle would it be okay to instead hide this behind $wgGlobalWatchlistEnableGuidedTour with a default of false, so that if the tour can be restored in the future everything is already there, rather than removing everything entirely?

I think that would be fine, as long as that variable wouldn't be set to true in WMF production (perhaps CS.php forcing it to be false?).

Sure, just in case the default is ever changed

DannyS712 renamed this task from Remove GuidedTour for Special:GlobalWatchlistSettings to Add an option to disable GuidedTour for Special:GlobalWatchlistSettings.Oct 8 2020, 6:49 PM

DannyS712 updated the task description. (Show Details)

Change 632990 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Add $wgGlobalWatchlistEnableGuidedTour

https://gerrit.wikimedia.org/r/632990

gerritbot added a project: Patch-For-Review.Oct 8 2020, 8:21 PM

Tested on patch demo, the patch above works. Since this is blocking the security review, I'd appreciate it if the patch could be reviewed as soon as possible - @Niharika @ashley can you take a look?