Page MenuHomePhabricator

Convert Cosmos to use ConfigRegistry
Closed, ResolvedPublic

Description

At some point I'd like to convert Cosmos to use the ConfigRegistry rather than the current Config.php.

Event Timeline

Universal_Omega triaged this task as Low priority.Oct 7 2020, 4:21 PM
Universal_Omega created this task.
Universal_Omega moved this task from Incoming / Backlog to Feature requests on the Cosmos board.

Change 633376 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Basic code cleanup in Cosmos\ResourceLoaderLessModule

https://gerrit.wikimedia.org/r/633376

Change 633377 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] ResourceLoaderLessModule: General code cleanup

https://gerrit.wikimedia.org/r/633377

Change 633582 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

Change 633582 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

Change 633762 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/skins/Cosmos@master] Convert to ConfigRegistry

https://gerrit.wikimedia.org/r/633762

Universal_Omega closed this task as Resolved.Oct 15 2020, 1:07 AM
Universal_Omega moved this task from In Progress to Done on the Cosmos board.

Change 633762 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Convert to ConfigRegistry

https://gerrit.wikimedia.org/r/633762

Change 633376 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Basic code cleanup in Cosmos\ResourceLoaderLessModule

https://gerrit.wikimedia.org/r/633376

Change 633377 abandoned by SamanthaNguyen:
[mediawiki/skins/Cosmos@master] ResourceLoaderLessModule: Make code more readable, match convention

Reason:
I could rebase this on top of master, but that's sort of annoying, so I'll make a new patch

https://gerrit.wikimedia.org/r/633377