⚓ T264908 Convert Cosmos to use HTML templating

Project	Branch	Lines +/-	Subject
mediawiki/skins/Cosmos	master	+13 -8	Cleanup CosmosTemplate->buildNavigation(), only access things when needed
mediawiki/skins/Cosmos	master	+24 -20	Use guard clause for readability in CosmosTemplate->buildFooterIcons()
mediawiki/skins/Cosmos	master	+40 -76	Technical debt cleanup: Remove unused parameters from methods

Status	Assigned	Task
Open	None	T264908 Convert Cosmos to use HTML templating
Resolved	SamanthaNguyen	T265232 Cosmos skin: Don't pass string variables by reference in CosmosTemplate
Open	None	T265109 Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class

Universal_Omega triaged this task as Low priority.Oct 7 2020, 4:24 PM

Universal_Omega moved this task from Incoming / Backlog to Feature requests on the Cosmos board.

SamanthaNguyen moved this task from Feature requests to Code hygiene on the Cosmos board.Oct 10 2020, 9:01 PM

Change 633582 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

gerritbot added a project: Patch-For-Review.Oct 12 2020, 10:21 PM

SamanthaNguyen added a subtask: T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate.Oct 12 2020, 10:28 PM

SamanthaNguyen added a subtask: T265109: Cosmos skin: Work on getting rid of the nasty Cosmos\Icon class.Oct 12 2020, 10:30 PM

Change 633582 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2020, 6:11 PM

SamanthaNguyen moved this task from Code hygiene to Incoming / Backlog on the Cosmos board.Oct 15 2020, 12:11 AM

SamanthaNguyen closed subtask T265232: Cosmos skin: Don't pass string variables by reference in CosmosTemplate as Resolved.Oct 15 2020, 7:31 PM

Change 634668 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Use guard clause for readability in CosmosTemplate->buildFooterIcons()

https://gerrit.wikimedia.org/r/634668

Change 634670 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Cleanup CosmosTemplate->buildNavigation(), only access things when needed

https://gerrit.wikimedia.org/r/634670

Change 634668 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Use guard clause for readability in CosmosTemplate->buildFooterIcons()

https://gerrit.wikimedia.org/r/634668

Change 634670 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Cleanup CosmosTemplate->buildNavigation(), only access things when needed

https://gerrit.wikimedia.org/r/634670

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2020, 4:10 PM

SamanthaNguyen raised the priority of this task from Low to Medium.Oct 17 2020, 4:12 PM