Page MenuHomePhabricator
Create Task
Maniphest T264925

Add P6243 (digital representation of) to MediaSearch algorithm
Closed, ResolvedPublic
Actions

Description

We have this:
The current MediaSearch algo only uses one structured data statement: P180 (depicts). However, files with artwork can use a separate property, P6243 (digital representation of).

We want this:
Include P6243 in the MediaSearch algorithm

Acceptance Criteria:

  • An indication that this is working properly - Searches for "the kiss" should return and prominently rank these results

During development, please test the following:

  • Test this feature while logged in AND logged out
  • Test this feature on at least one mobile browser

Details

SubjectRepoBranchLines +/-
Add another SDC property to search for matching media statementsoperations/mediawiki-configmaster+12 -0
Allow other properties to be searchedmediawiki/extensions/WikibaseMediaInfomaster+17 -12
Customize query in gerrit

Related Objects

Mentioned Here
P2643 pdns logfile dump

Event Timeline

• Ramsey-WMF created this task.Oct 7 2020, 6:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2020, 6:25 PM
• Ramsey-WMF updated the task description. (Show Details)Oct 7 2020, 6:26 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 9 2020, 5:45 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.Oct 9 2020, 5:53 PM
gerritbot added a comment.Oct 14 2020, 11:33 AM

Change 633978 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Allow other properties to be searched

https://gerrit.wikimedia.org/r/633978

gerritbot added a project: Patch-For-Review.Oct 14 2020, 11:33 AM
matthiasmullie subscribed.Oct 14 2020, 11:52 AM

I suspect we want to rank 'digital representation of' slightly better than 'depicts' matches (given that it's more specific)?

gerritbot added a comment.Oct 14 2020, 11:56 AM

Change 633982 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[operations/mediawiki-config@master] Add another SDC property to search for matching media statements

https://gerrit.wikimedia.org/r/633982

matthiasmullie claimed this task.Oct 14 2020, 11:56 AM
matthiasmullie moved this task from Ready for Estimation to Code Review on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Oct 20 2020, 6:35 PM

Change 633978 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Allow other properties to be searched

https://gerrit.wikimedia.org/r/633978

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 20 2020, 7:00 PM
gerritbot added a comment.Oct 29 2020, 11:10 AM

Change 633982 merged by jenkins-bot:
[operations/mediawiki-config@master] Add another SDC property to search for matching media statements

https://gerrit.wikimedia.org/r/633982

Stashbot added a comment.Oct 29 2020, 11:12 AM

Mentioned in SAL (#wikimedia-operations) [2020-10-29T11:12:49Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 28152b7387082b79d71cfbf28be740ffe629ee50: Add another SDC property to search for matching media statements (T264925) (duration: 00m 58s)

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 12:10 PM
• Ramsey-WMF added a comment.Nov 9 2020, 6:58 PM

I verified this code is on production (via a search for Atlas van Dirk van der Hagen, with a result that could only be found via that text because it has a corresponding P2643 statement). However, we're still not getting the desired results for "The Kiss". Thoughts, @matthiasmullie ? 🤔

matthiasmullie added a comment.Nov 10 2020, 9:32 AM

Yeah looks like it's working. The second result (File:The Kiss - Gustav Klimt - Google Cultural Institute.jpg) is one of P2643=Q698487 and is largely in that position because of that statement.
A lot of others are being drowned out by many other file with (title/description) occurrences of "kiss", though - that balance is another problem (that we're currently looking into!)

matthiasmullie closed this task as Resolved.Nov 10 2020, 9:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL