MediaWiki::restInPeace: transaction round 'Cognate\CacheUpdateJob::run' still running
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	BPirkle
	Oct 7 2020, 6:51 PM

Description

Error

MediaWiki version: 1.36.0-wmf.10

message

MediaWiki::restInPeace: transaction round 'Cognate\CacheUpdateJob::run' still running

Impact

Notes

4 occurrences for request id 94940455-73d1-4702-ac31-ff91f1cd1a29 seen on these 4 wikis:
jawiktionary
chrwiktionary
kowiktionary
zhwiktionary

exception.class: Wikimedia\Rdbms\DBTransactionError
exception.code: 0

Details

Request ID: 94940455-73d1-4702-ac31-ff91f1cd1a29
Request URL: https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.36.0-wmf.10/includes/MediaWiki.php(1101): Wikimedia\Rdbms\LBFactory->commitMasterChanges(string)
#1 /srv/mediawiki/rpc/RunSingleJob.php(93): MediaWiki->restInPeace()
#2 {main}

	Subject	Repo	Branch	Lines +/-
	Push the HTMLCacheUpdateJob instead of running it.	mediawiki/extensions/Cognate	master	+5 -3

Customize query in gerrit

Event Timeline

BPirkle created this task.Oct 7 2020, 6:51 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 7 2020, 6:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I can't be sure, but it seems likely that this is causing the job to fatal and/or some part of the job updates to not have actually been committed to the DB. Might be high prio?

@Micheal @Addshore Ping for triage :) this may've been missed given its age.

Looks like this is still occurring in 1.36.0-wmf.14 too on a variety of wikis

This cognate job just wraps a HtmlCacheUpdateJob
https://github.com/wikimedia/mediawiki-extensions-Cognate/blob/master/src/CacheUpdateJob.php#L30-L41

Nothing has changed in Cognate in a long time, so perhaps something has change in core or that job?

Can it push the job instead of running it? I make a patch for it.

Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptJan 26 2021, 5:48 AM

Change 658549 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Cognate@master] Push the HTMLCacheUpdateJob instead of running it.

https://gerrit.wikimedia.org/r/658549

gerritbot added a project: Patch-For-Review.Jan 26 2021, 8:07 AM

Addshore moved this task from Inbox to legacy-backlog on the [DEPRECATED] wdwb-tech board.Jan 27 2021, 1:59 PM

Addshore edited projects, added [DEPRECATED] wdwb-tech (legacy-backlog); removed [DEPRECATED] wdwb-tech.

Addshore moved this task from Incoming to Active on the [DEPRECATED] wdwb-tech (legacy-backlog) board.

Ladsgroup claimed this task.Feb 1 2021, 7:12 AM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFeb 1 2021, 7:12 AM

Change 658549 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Push the HTMLCacheUpdateJob instead of running it.

https://gerrit.wikimedia.org/r/658549

Maintenance_bot removed a project: Patch-For-Review.Feb 1 2021, 9:10 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Feb 1 2021, 1:00 PM

Ladsgroup closed this task as Resolved.Feb 19 2021, 7:36 AM

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Feb 19 2021, 8:15 AM

	F32418103: image.png
	Oct 28 2020, 10:39 PM

MediaWiki::restInPeace: transaction round 'Cognate\CacheUpdateJob::run' still runningClosed, ResolvedPublicPRODUCTION ERRORActions