Page MenuHomePhabricator
Create Task
Maniphest T264992

Remove mobile-details mode from Special:Homepage
Open, MediumPublic
Actions

Description

Tasks:

  • Remove RENDER_MOBILE_DETAILS from IDashboardModule
  • Remove references to RENDER_MOBILE_DETAILS throughought codebase
  • Remove LESS used to accomodate RENDER_MOBILE_DETAILS ---

Notes:

Our first pass at mobile support for Special:Homepage involved using subpages, in the format Special:Homepage/{moduleName}, and these modules were all rendered on the server-side, not requiring any JavaScript to load.

Then we switched to using the mobile overlays provided by MobileFrontend / Minerva to offer a smoother experience to mobile users: Special:Homepage#/homepage/{moduleName}

Since then we have largely focused on the latter (mobile overlay) and fairly little on mobile detail.

This task would involve:

  1. checking to see how many mobile-detail events we are recording in proportion to the overall number of mobile events
  2. deciding if we want to keep supporting the mobile-detail view

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT340453 [Epic] FY 2023-24 Growth Maintenance Work
 OpenNoneT264992 Remove mobile-details mode from Special:Homepage

Event Timeline

kostajh created this task.Oct 8 2020, 8:44 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 8 2020, 8:44 AM
kostajh mentioned this in T262485: Variant C/D: instrumentation.Oct 8 2020, 8:44 AM
kostajh added a project: Technical-Debt.Dec 10 2021, 9:50 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 10 2021, 9:50 AM
kostajh mentioned this in T264460: Enable users to open the first suggested article directly from the mobile task preview.Dec 10 2021, 10:00 AM
Sgs subscribed.Dec 10 2021, 10:05 AM
kostajh mentioned this in T297477: Visual design bugs in the standalone Suggested edits feed on mobile.Dec 10 2021, 12:28 PM
• mewoph subscribed.Dec 10 2021, 8:54 PM

Moving to needs discussion (in tandem w/T297477: Visual design bugs in the standalone Suggested edits feed on mobile)

• mewoph moved this task from Inbox to Needs Discussion on the Growth-Team board.Dec 10 2021, 8:54 PM
• mewoph added a subscriber: nettrom_WMF.Jan 10 2022, 11:00 PM

Per @nettrom_WMF:

If we aggregate on a per-session basis, it’s 1% of all mobile sessions. If we aggregate on a per-user basis, it’s 1.6% of all users. I think that makes sense if we expect users who visit multiple times to not use it extensively.

I'll add this to the agenda for the next engineering sync to confirm the next course of action based on these numbers.

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Feb 1 2022, 2:19 PM

In our meeting yesterday we decided to remove the mobile details render view to simplify the codebase.

kostajh renamed this task from Consider removing mobile-details mode from Special:Homepage to Remove mobile-details mode from Special:Homepage.Feb 1 2022, 2:19 PM
kostajh triaged this task as Medium priority.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh removed a project: Growth Design.
kostajh edited projects, added GrowthExperiments; removed GrowthExperiments-Homepage.
kostajh updated the task description. (Show Details)
MShilova_WMF added a parent task: T304427: [Epic] Q4 FY 2021-22 Growth Maintenance Work.Mar 31 2022, 4:20 PM
MShilova_WMF edited parent tasks, added: T311850: [Epic] FY 2022-23 Growth Maintenance Work; removed: T304427: [Epic] Q4 FY 2021-22 Growth Maintenance Work.Jul 1 2022, 3:04 PM
MShilova_WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Aug 1 2022, 4:59 PM
MShilova_WMF moved this task from Needs Discussion to Upcoming Work on the Growth-Team board.
MShilova_WMF moved this task from Upcoming Work to Triaged on the Growth-Team board.Nov 7 2022, 6:21 PM
kostajh awarded a token.Feb 27 2023, 6:52 PM
kostajh mentioned this in T337314: [BUG] New impact empty module is loading without CTA and with mobile headers.May 30 2023, 10:41 AM
Sgs mentioned this in T335005: New Impact module empty state - minor improvements.Jun 14 2023, 11:02 AM
kostajh added a comment.Jun 20 2023, 10:41 AM

One way to do this would be to adjust SpecialHomepage::renderMobileSummary() to do $module->setPageURL( '#' );. That doesn't disable mobile details mode, but it makes it highly unlikely for a newcomer to end up on the mobile details rendering of a homepage module.

The downside is that, until the browser loads the homepage JS, the server-side rendered modules will not be clickable. It would be nice to have some loading indicator while we wait for the JS to bind to the module CSS classes.

DMburugu edited parent tasks, added: T340453: [Epic] FY 2023-24 Growth Maintenance Work; removed: T311850: [Epic] FY 2022-23 Growth Maintenance Work.Jun 26 2023, 4:04 PM
Sgs mentioned this in T343178: [wmf.20 - mobile] closing New Impact drawer closes Impact overlay.Aug 8 2023, 9:45 AM
Michael subscribed.Jul 9 2024, 9:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits