Page MenuHomePhabricator

Test instance: Use TemplateData order in sidebar and content pane
Closed, ResolvedPublic0 Estimated Story Points

Description

Order parameters based on:

  • If existing, use TemplateData order (ParamOrder or order of parameters as listed in TemplateData)
  • If TemplateData is missing, auto-order based on the order of parameters in the template definition/source code

Ignore:

  • Parameter order in template invocation/wikitext, if editing an already inserted template

Event Timeline

ECohen_WMDE renamed this task from [Design] Choose order for template parameters to Test instance: Changer oder of parameters in sidebar.Oct 13 2020, 1:06 PM
ECohen_WMDE renamed this task from Test instance: Changer oder of parameters in sidebar to Test instance: Change order of parameters in sidebar.
ECohen_WMDE updated the task description. (Show Details)
ECohen_WMDE renamed this task from Test instance: Change order of parameters in sidebar to Test instance: Use TemplateData order in sidebar.Oct 15 2020, 7:37 AM

As far as I can see there is nothing to do here. The order is exactly as for asked in the task description, by default. At least in the sidebar. There is an issue that makes the parameters appear in a random order on the right side of the dialog. I was able to track this issue down to a addPages call in ve.ui.MWTemplateDialog.prototype.onReplacePart. I believe the index for a new parameter is calculated based on a model that contains a different amount of parameters, or in a different order. Should this be part of this ticket or a new one?

awight renamed this task from Test instance: Use TemplateData order in sidebar to Test instance: Use TemplateData order in sidebar and content pane.Oct 15 2020, 11:25 AM

Order should be the same in the sidebar and content pane, so I've expanded the scope of this task.

We also need to handle unknown parameters. Alphabetical, or in order added?

Order should be the same in the sidebar and content pane, so I've expanded the scope of this task.

Thanks. Didn't realize that the ordering was off in the content pane. The two panes matching each other should be a requirement for this ticket.

We also need to handle unknown parameters. Alphabetical, or in order added?

Thanks for catching this - thought I added this to a ticket but can't find it at the moment and makes sense for it to be here. Let's use order added, and always starting below any existing/documented parameters.

conny-kawohl_WMDE set the point value for this task to 8.
thiemowmde moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-10-07 board.

This is unfortunately not yet working for me - example, try adding Infobox book on the english test instance (or see here: https://en-wmde-templates-alpha.wmcloud.org/wiki/User:Elco?veaction=edit). The parameter 'Border' shows up in the correct place on the right hand side, but not in the left sidebar. (See TemplateData order: https://en-wmde-templates-alpha.wmcloud.org/wiki/Template:Infobox_book/doc)

A fix is prepared in https://gitlab.com/wmde/mediawiki-extensions-VisualEditor/-/merge_requests/7 , but not on the test instance because it depends on a work-in-progress branch.

Lena_WMDE changed the point value for this task from 8 to 0.

This is done, just waiting for merge.

awight moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-10-21 board.
thiemowmde claimed this task.