Page MenuHomePhabricator
Create Task
Maniphest T265045

Omit external_services from the Manifest response if none are set for the Wikibase
Closed, ResolvedPublic
Actions

Description

In light of our decision to represent lack of value of optional spec properties by omitting the property from the response, we need to do that for the external_services part of the response.

Details

SubjectRepoBranchLines +/-
Omit all empty properties from the manifest responsemediawiki/extensions/WikibaseManifestmaster+95 -27
Customize query in gerrit

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Oct 8 2020, 2:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2020, 2:36 PM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)Oct 8 2020, 2:36 PM
• Tonina_Zhelyazkova_WMDE added a project: Wikidata.Oct 8 2020, 3:07 PM
• Tonina_Zhelyazkova_WMDE claimed this task.Oct 9 2020, 8:53 AM
• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikibase - Automated Configuration Detection (WikibaseManifest) (Sprint 4) board.
gerritbot added a comment.Oct 9 2020, 12:47 PM

Change 633175 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseManifest@master] Omit all empty properties from the manifest response

https://gerrit.wikimedia.org/r/633175

gerritbot added a project: Patch-For-Review.Oct 9 2020, 12:47 PM
gerritbot added a comment.Oct 12 2020, 10:48 AM

Change 633175 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseManifest@master] Omit all empty properties from the manifest response

https://gerrit.wikimedia.org/r/633175

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Peer Review on the Wikibase - Automated Configuration Detection (WikibaseManifest) (Sprint 4) board.Oct 12 2020, 2:56 PM
gerritbot added a comment.Oct 12 2020, 3:52 PM

Change 633175 merged by jenkins-bot:
[mediawiki/extensions/WikibaseManifest@master] Omit all empty properties from the manifest response

https://gerrit.wikimedia.org/r/633175

• Tonina_Zhelyazkova_WMDE moved this task from Peer Review to Done on the Wikibase - Automated Configuration Detection (WikibaseManifest) (Sprint 4) board.Oct 12 2020, 4:09 PM
darthmon_wmde closed this task as Resolved.Oct 21 2020, 10:28 AM
Nintendofan885 removed a project: Patch-For-Review.Oct 21 2020, 1:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL