Page MenuHomePhabricator
Create Task
Maniphest T265091

element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms
Closed, ResolvedPublic
Actions

Description

Seen on a vendor patch bumping monolog...

https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/579666/

https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/63166/console

22:00:40 [chrome 73.0.3683.75 Linux #0-6] Spec: /workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/specs/editing.spec.js
22:00:40 [chrome 73.0.3683.75 Linux #0-6] Running: chrome (v73.0.3683.75) on Linux
22:00:40 [chrome 73.0.3683.75 Linux #0-6] Session ID: 91a1c5b49548168ed6dc4e6196b81c96
22:00:40 [chrome 73.0.3683.75 Linux #0-6]
22:00:40 [chrome 73.0.3683.75 Linux #0-6] Termbox: editing
22:00:40 [chrome 73.0.3683.75 Linux #0-6]     edit mode
22:00:40 [chrome 73.0.3683.75 Linux #0-6]        ✓ is in edit mode after clicking the edit button
22:00:40 [chrome 73.0.3683.75 Linux #0-6]        ✓ switches back to reading mode when clicking the cancel button
22:00:40 [chrome 73.0.3683.75 Linux #0-6]
22:00:40 [chrome 73.0.3683.75 Linux #0-6]     editing
22:00:40 [chrome 73.0.3683.75 Linux #0-6]        ✖ can edit labels, descriptions, and aliases
22:00:40 [chrome 73.0.3683.75 Linux #0-6]        ✓ shows an error banner when an edit fails to save when the entity was protected while editing
22:00:40 [chrome 73.0.3683.75 Linux #0-6]
22:00:40 [chrome 73.0.3683.75 Linux #0-6] 3 passing (29.4s)
22:00:40 [chrome 73.0.3683.75 Linux #0-6] 1 failing
22:00:40 [chrome 73.0.3683.75 Linux #0-6]
22:00:40 [chrome 73.0.3683.75 Linux #0-6] 1) editing can edit labels, descriptions, and aliases
22:00:40 [chrome 73.0.3683.75 Linux #0-6] element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms
22:00:40 [chrome 73.0.3683.75 Linux #0-6] Error: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms
22:00:40 [chrome 73.0.3683.75 Linux #0-6]     at TermboxPage.waitUntilSaved (/workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/pageobjects/Termbox.page.js:117:19)
22:00:40 [chrome 73.0.3683.75 Linux #0-6]     at Context.it (/workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/specs/editing.spec.js:48:16)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update Termbox (CI fix)mediawiki/extensions/Wikibasemaster+1 -1
Increase wait-for-save timeout from 3 to 20 secondswikibase/termboxmaster+1 -1
tests: Disable two flaky selenium testswikibase/termboxmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Oct 8 2020, 9:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2020, 9:32 PM
Reedy added projects: Browser-Tests, MediaWiki-extensions-WikibaseView.Oct 8 2020, 10:47 PM
Daimona subscribed.Oct 29 2020, 12:34 AM

Dupe of T264926?

Reedy added a comment.Oct 29 2020, 12:37 AM
In T265091#6586789, @Daimona wrote:

Dupe of T264926?

Doesn't seem to be... I don't see wb-ui-event-emitting-button--edit mentioned in that bug... Similar/related? sure

Daimona added a comment.Oct 29 2020, 12:38 AM
In T265091#6586803, @Reedy wrote:
In T265091#6586789, @Daimona wrote:

Dupe of T264926?

Doesn't seem to be... I don't see wb-ui-event-emitting-button--edit mentioned in that bug... Similar/related? sure

Yeah, there seems to be a bunch of tests failing randomly. I think no-one really knows why, and for as much as we know, it might be some upstream problem with wdio.

Ammarpad subscribed.Jan 20 2021, 8:14 PM

Still happening https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/76468/console

Nikerabbit mentioned this in T264926: Wikibase Selenium tests are flaky.Feb 15 2021, 11:06 AM
Addshore changed the task status from Open to Stalled.Mar 4 2021, 9:09 PM
Addshore subscribed.

It's very hard to investigate this without the full logs.
All logs that were linked to in this task have already expired.
Thus I will mark as stalled now waiting for this further data / input

Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptMar 4 2021, 9:09 PM
Addshore moved this task from Inbox to LEGACY Freezer 🥶 on the [DEPRECATED] wdwb-tech board.Mar 5 2021, 11:46 AM
Addshore removed a project: Wikidata-Campsite.Apr 22 2021, 4:03 PM
Addshore moved this task from LEGACY Freezer 🥶 to Freezer 🥶 on the [DEPRECATED] wdwb-tech board.Jul 20 2021, 8:56 AM
Addshore edited projects, added [DEPRECATED] wdwb-tech (Freezer 🥶); removed [DEPRECATED] wdwb-tech.
Restricted Application edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (Freezer 🥶). · View Herald TranscriptJul 20 2021, 8:56 AM
Addshore moved this task from Inbox to Freezer 🥶 on the [DEPRECATED] wdwb-tech board.Jul 20 2021, 9:01 AM
Addshore edited projects, added [DEPRECATED] wdwb-tech (Freezer 🥶); removed [DEPRECATED] wdwb-tech.
Lens0021 subscribed.Oct 12 2021, 1:59 PM
Umherirrender subscribed.Feb 18 2022, 8:59 PM

Failure was also at https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/136871/console

Maybe there are enough logs/artifacts
Often it helps to check .waitForDisplayed() before clicking the button (example https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/759581)

Ammarpad unsubscribed.Feb 18 2022, 9:03 PM
Krinkle subscribed.EditedFeb 22 2022, 6:32 PM

Still seen at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/764445 (build 137348).

Error in "Termbox: LicenseOverlay.disappears and saves when clicking publish"
Error: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms
  at …
  at TermboxPage.waitUntilSaved (/workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/pageobjects/Termbox.page.js:117:19)
  at Context.<anonymous> (/workspace/src/extensions/Wikibase/view/lib/wikibase-termbox/tests/selenium/specs/LicenseOverlay.spec.js:37:15)

Please consider disabling this test. I'd do it but I couldn't find the file in my local copy. Is it generated by something?

gerritbot added a comment.Feb 22 2022, 6:40 PM

Change 764865 had a related patch set uploaded (by Krinkle; author: Krinkle):

[wikibase/termbox@master] selenium: Disable two flaky LicenseOverlay tests

https://gerrit.wikimedia.org/r/764865

gerritbot added a project: Patch-For-Review.Feb 22 2022, 6:40 PM
gerritbot added a comment.Feb 23 2022, 2:37 PM

Change 765275 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikibase/termbox@master] Increase wait-for-save timeout from 3 to 20 seconds

https://gerrit.wikimedia.org/r/765275

gerritbot added a comment.Feb 25 2022, 3:17 PM

Change 764865 abandoned by Krinkle:

[wikibase/termbox@master] tests: Disable two flaky selenium tests

Reason:

https://gerrit.wikimedia.org/r/764865

Krinkle changed the task status from Stalled to Open.Feb 25 2022, 3:17 PM
Krinkle assigned this task to Lucas_Werkmeister_WMDE.
gerritbot added a comment.Feb 25 2022, 4:19 PM

Change 765275 merged by jenkins-bot:

[wikibase/termbox@master] Increase wait-for-save timeout from 3 to 20 seconds

https://gerrit.wikimedia.org/r/765275

gerritbot added a comment.Feb 25 2022, 4:24 PM

Change 766148 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update Termbox (CI fix)

https://gerrit.wikimedia.org/r/766148

Lucas_Werkmeister_WMDE mentioned this in rWBTBbc469e29fb44: Increase wait-for-save timeout from 3 to 20 seconds.Feb 25 2022, 5:19 PM
gerritbot added a comment.Feb 25 2022, 5:30 PM

Change 766148 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update Termbox (CI fix)

https://gerrit.wikimedia.org/r/766148

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 25 2022, 6:00 PM
Umherirrender unsubscribed.Mar 15 2022, 10:20 PM
Addshore unsubscribed.Jun 27 2023, 12:35 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 27 2023, 1:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 15 2024, 2:25 PM

Apparently this was still open and assigned to me… let’s assume it’s fixed, feel free to reopen otherwise. (There’s been some movement in these browser tests anyways, e.g. they’ve been ported to async mode in T300807.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits