Page MenuHomePhabricator

Tag errors where a banner is being displayed
Open, HighPublic

Description

There have been a few errors relating to banners recently that have been extremely hard to debug (T264786, T264952)
The error client could provide a clue to a banner being the cause by adding the value of mw.centralNotice.isBannerShown()

Note it's possible we could even log the name of the banner mw.centralNotice.getDataProperty( 'banner' ); but that warrants further investigation and the boolean should be sufficient enough for now.

The tag will also allow us to create a fundraising banner dashboard for catching and addressing these errors as banners are enabled.

Event Timeline

Change 633034 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikimediaEvents@master] Tag errors when a banner is displayed

https://gerrit.wikimedia.org/r/633034

(blocker for rolling out to enwiki)

Change 634295 had a related patch set uploaded (by Jdlrobson; owner: Jason Linehan):
[mediawiki/extensions/WikimediaEvents@master] clientError: Adds 'is_user_logged_in' and 'is_banner_shown' fields

https://gerrit.wikimedia.org/r/634295

Change 633034 abandoned by Jdlrobson:
[mediawiki/extensions/WikimediaEvents@master] Tag errors when a banner is displayed

Reason:
Since a schema change is required this is being done as part of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/ /634295

https://gerrit.wikimedia.org/r/633034