Page MenuHomePhabricator
Create Task
Maniphest T265108

Cosmos skin: Fix all remaining PHPCS issues
Closed, ResolvedPublic
Actions

Description

We have PHPCS setup now in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Cosmos/+/633045, with some issues fixed so far. There's still much more left though. Let's work on enabling all of these.

  • Merged: patchset 633316
    • Generic.Arrays.DisallowLongArraySyntax.Found
    • Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma
    • Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
  • Merged: patchset 633302
    • Generic.PHP.ForbiddenFunctions.FoundWithAlternative
    • MediaWiki.Usage.ForbiddenFunctions.sizeof
  • Merged: patchset 633305
    • Generic.ControlStructures.InlineControlStructure.NotAllowed
    • MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse
  • Merged: patchset 633050
    • MediaWiki.Classes.UnusedUseStatement.UnnecessaryUse
    • MediaWiki.Classes.UnsortedUseStatements.UnsortedUse
    • MediaWiki.Classes.UnusedUseStatement.UnusedUse
  • Merged: patchset 633324
    • MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
    • MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.SingleSpaceBeforeSingleLineComment
  • Merged: patchset 633289
    • PSR12.Files.ImportStatement.LeadingSlash
    • PSR12.Properties.ConstantVisibility.NotFound
  • Merged: patchset 633051
    • PSR2.Classes.PropertyDeclaration.ScopeMissing
    • PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
    • PSR2.Files.EndFileNewline.TooMany
    • PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose
    • PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter
    • PSR2.Namespaces.UseDeclaration.SpaceAfterLastUse
  • Merged: patchset 633290
    • Squiz.Classes.SelfMemberReference.SpaceBefore
    • Squiz.Classes.SelfMemberReference.NotUsed

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

SamanthaNguyen renamed this task from Fix all remaining PHPCS issues to Cosmos skin: Fix all remaining PHPCS issues.Oct 9 2020, 4:27 AM
SamanthaNguyen triaged this task as Medium priority.
SamanthaNguyen created this task.
SamanthaNguyen moved this task from Incoming / Backlog to Code hygiene on the Cosmos board.Oct 9 2020, 4:30 AM
gerritbot added a comment.Oct 10 2020, 6:20 AM

Change 633289 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues related to PSR-12 standard sniffs

https://gerrit.wikimedia.org/r/633289

gerritbot added a project: Patch-For-Review.Oct 10 2020, 6:20 AM
SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 6:20 AM
SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 6:24 AM
gerritbot added a comment.Oct 10 2020, 6:31 AM

Change 633289 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues related to PSR-12 standard sniffs

https://gerrit.wikimedia.org/r/633289

Sam Nguyen <sam.t.nguyenn@gmail.com> mentioned this in rSCOS7ad9b5bb2cb4: PHPCS: Fix styling issues related to PSR-12 standard sniffs.Oct 10 2020, 6:32 AM
gerritbot added a comment.Oct 10 2020, 6:32 AM

Change 633290 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues related to self member references

https://gerrit.wikimedia.org/r/633290

SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 6:38 AM
gerritbot added a comment.Oct 10 2020, 7:24 AM

Change 633290 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues related to self member references

https://gerrit.wikimedia.org/r/633290

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2020, 8:10 AM
SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 12:45 PM
SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 12:49 PM
gerritbot added a comment.Oct 10 2020, 3:08 PM

Change 633302 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues related to forbidden PHP functions

https://gerrit.wikimedia.org/r/633302

gerritbot added a project: Patch-For-Review.Oct 10 2020, 3:08 PM
SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 3:09 PM
gerritbot added a comment.Oct 10 2020, 3:36 PM

Change 633305 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix most styling issues related to control structures

https://gerrit.wikimedia.org/r/633305

SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 3:38 PM
SamanthaNguyen mentioned this in T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code.Oct 10 2020, 4:04 PM
SamanthaNguyen added a parent task: T265193: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code.Oct 10 2020, 4:06 PM
gerritbot added a comment.Oct 10 2020, 4:40 PM

Change 633302 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues related to forbidden PHP functions

https://gerrit.wikimedia.org/r/633302

gerritbot added a comment.Oct 10 2020, 4:42 PM

Change 633305 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix most styling issues related to control structures

https://gerrit.wikimedia.org/r/633305

SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 4:47 PM
SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 4:53 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 10 2020, 5:10 PM
SamanthaNguyen mentioned this in T265195: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation.Oct 10 2020, 5:25 PM
gerritbot added a comment.Oct 10 2020, 5:54 PM

Change 633316 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix most styling issues related to generic sniffs

https://gerrit.wikimedia.org/r/633316

gerritbot added a project: Patch-For-Review.Oct 10 2020, 5:54 PM
SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 6:07 PM
gerritbot added a comment.Oct 10 2020, 6:16 PM

Change 633317 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix undeclared visibility on methods

https://gerrit.wikimedia.org/r/633317

SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 6:19 PM
gerritbot added a comment.Oct 10 2020, 6:29 PM

Change 633316 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix most styling issues related to generic sniffs

https://gerrit.wikimedia.org/r/633316

gerritbot added a comment.Oct 10 2020, 6:30 PM

Change 633317 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix undeclared visibility on methods

https://gerrit.wikimedia.org/r/633317

gerritbot added a comment.Oct 10 2020, 6:54 PM

Change 633318 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues related to empty lines

https://gerrit.wikimedia.org/r/633318

gerritbot added a comment.Oct 10 2020, 7:07 PM

Change 633318 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues related to empty lines

https://gerrit.wikimedia.org/r/633318

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2020, 7:10 PM
gerritbot added a comment.Oct 10 2020, 7:26 PM

Change 633324 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix spacing issues in single-lined comments

https://gerrit.wikimedia.org/r/633324

gerritbot added a project: Patch-For-Review.Oct 10 2020, 7:26 PM
gerritbot added a comment.Oct 10 2020, 7:39 PM

Change 633324 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix spacing issues in single-lined comments

https://gerrit.wikimedia.org/r/633324

SamanthaNguyen updated the task description. (Show Details)Oct 10 2020, 7:44 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 10 2020, 8:10 PM
SamanthaNguyen added a comment.Oct 10 2020, 9:09 PM
  • the Generic.Files.LineLength.TooLong will need to be manually fixed, same with the MediaWiki.Commenting.* sniffs
  • the SpaceyParenthesis sniffs can be auto-fixed but needs careful review since it will end up fixing at least ~2600+ detected errors
  • the rest of the Squiz sniffs are auto-fixable, and can maybe be all done in one patch (depends how many fixes there are, if it's like the SpaceyParenthesis sniffs, then it will need to be split up)
  • MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures needs manually fixing
  • MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName needs manually fixing
SamanthaNguyen added a comment.Oct 10 2020, 9:12 PM

Except MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation, which can be auto-fixed

gerritbot added a comment.Oct 11 2020, 5:26 PM

Change 633360 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Enable all Squiz standard sniffs and auto-fix styling issues

https://gerrit.wikimedia.org/r/633360

gerritbot added a project: Patch-For-Review.Oct 11 2020, 5:26 PM
gerritbot added a comment.Oct 11 2020, 5:47 PM

Change 633362 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues for spaces and parentheses

https://gerrit.wikimedia.org/r/633362

gerritbot added a comment.Oct 11 2020, 5:55 PM

Change 633360 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Enable all Squiz standard sniffs and auto-fix styling issues

https://gerrit.wikimedia.org/r/633360

gerritbot added a comment.Oct 11 2020, 6:05 PM

Change 633362 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix styling issues for spaces and parentheses

https://gerrit.wikimedia.org/r/633362

gerritbot added a comment.Oct 11 2020, 7:29 PM

Change 633375 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix name casing of methods, remove unrecognized PHP annotation

https://gerrit.wikimedia.org/r/633375

gerritbot added a comment.Oct 11 2020, 9:52 PM

Change 633375 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix name casing of methods, remove unrecognized PHP annotation

https://gerrit.wikimedia.org/r/633375

gerritbot added a comment.Oct 12 2020, 5:07 AM

Change 633384 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] PHPCS: Fix all MediaWiki function comment styling issues

https://gerrit.wikimedia.org/r/633384

gerritbot added a comment.Oct 12 2020, 1:52 PM

Change 633384 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: Fix all MediaWiki function comment styling issues

https://gerrit.wikimedia.org/r/633384

SamanthaNguyen moved this task from Code hygiene to In Progress on the Cosmos board.Oct 15 2020, 12:09 AM
SamanthaNguyen changed the task status from Open to Stalled.Oct 15 2020, 11:15 PM

This is now stalled as this requires fixing MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures, which requires refactoring CosmosSocialProfile::getMostWantedPages()

SamanthaNguyen lowered the priority of this task from Medium to Low.Oct 17 2020, 6:56 PM

Not as high of a priority now, since most are done. (not all are done yet, just two left)

SamanthaNguyen removed a project: Patch-For-Review.Oct 19 2020, 6:29 PM
Universal_Omega changed the task status from Stalled to Open.Jan 12 2021, 4:44 PM
gerritbot added a comment.Jan 12 2021, 4:45 PM

Change 655670 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/skins/Cosmos@master] PHPCS: fix MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate

https://gerrit.wikimedia.org/r/655670

gerritbot added a project: Patch-For-Review.Jan 12 2021, 4:46 PM
gerritbot added a comment.Jan 12 2021, 5:02 PM

Change 655670 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] PHPCS: fix MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate

https://gerrit.wikimedia.org/r/655670

gerritbot added a comment.Jan 12 2021, 5:36 PM

Change 655675 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/skins/Cosmos@master] PHPCS: Fix Generic.Files.LineLength.TooLong

https://gerrit.wikimedia.org/r/655675

gerritbot added a comment.Jan 13 2021, 9:30 PM

Change 655675 merged by Universal Omega:
[mediawiki/skins/Cosmos@master] PHPCS: Fix Generic.Files.LineLength.TooLong (Part-1)

https://gerrit.wikimedia.org/r/655675

Universal_Omega changed the task status from Open to Stalled.Jan 14 2021, 4:21 AM

Stalling again since this is now blocked on T265109: Cosmos skin: Work on getting rid of the nasty MediaWiki\Skin\Cosmos\Icon class since that requires fixing what remains on Generic.Files.LineLength.TooLong

Universal_Omega added a subtask: T265109: Cosmos skin: Work on getting rid of the nasty MediaWiki\Skin\Cosmos\Icon class.Jan 14 2021, 5:08 PM
Universal_Omega changed the task status from Stalled to Open.Jan 14 2021, 5:48 PM
gerritbot added a comment.Jan 14 2021, 5:51 PM

Change 656167 had a related patch set uploaded (by Universal Omega; owner: Daimona Eaytoy):
[mediawiki/skins/Cosmos@master] Break long lines

https://gerrit.wikimedia.org/r/656167

gerritbot added a comment.Jan 14 2021, 6:01 PM

Change 656167 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Break long lines

https://gerrit.wikimedia.org/r/656167

Universal_Omega closed this task as Resolved.Jan 14 2021, 6:05 PM
Universal_Omega claimed this task.
Universal_Omega removed a subtask: T265109: Cosmos skin: Work on getting rid of the nasty MediaWiki\Skin\Cosmos\Icon class.
Universal_Omega moved this task from In Progress to Done on the Cosmos board.Jan 14 2021, 6:07 PM
Universal_Omega removed a project: Patch-For-Review.Jun 27 2021, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL