Page MenuHomePhabricator

Cosmos skin: Replace calls to global function wfMessage()
Closed, ResolvedPublic

Description

There's plenty of instances where we can use $this->msg() because we have access to an instance of an object that implements MessageLocalizer (e.g OutputPage extends ContextSource, which implements MessageLocalizer). We can also inject a MessageLocalizer and turn things into services.

Event Timeline

SamanthaNguyen triaged this task as Medium priority.Oct 11 2020, 5:56 PM

Change 634140 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Cleanup checks for checking contents of i18n messages

https://gerrit.wikimedia.org/r/634140

Change 634140 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Cleanup checks for checking contents of i18n messages

https://gerrit.wikimedia.org/r/634140

Change 634352 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Inject a MessageLocalizer into CosmosNavigation and CosmosToolbar

https://gerrit.wikimedia.org/r/634352

Change 634352 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Replace most calls to the global wfMessage() function

https://gerrit.wikimedia.org/r/634352

SamanthaNguyen closed this task as Resolved.Oct 15 2020, 11:01 PM
SamanthaNguyen claimed this task.
SamanthaNguyen removed a project: Patch-For-Review.
SamanthaNguyen moved this task from In Progress to Done on the Cosmos board.