Page MenuHomePhabricator
Create Task
Maniphest T265128

Replace all occurrences of "basestring"
Closed, ResolvedPublic
Actions

Description

Replace all occurrences of Python 2 basestring by str. But replace epydoc basestring type hints by typing annotation hints e.g.

def foo(bar):
"""Sample function.

@param bar: a sample Parameter
@type bar: basestring
"""
pass

should become

def foo(bar: str):
"""Sample function.

@param bar: a sample Parameter
"""
pass

https://codesearch.wmcloud.org/pywikibot/?q=basestring&i=nope&files=&repos=

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 InvalidNoneT223529 Pywikibot good first bugs (tracking)
 ResolvedUdoka_UgoT265128 Replace all occurrences of "basestring"

Event Timeline

Xqt created this task.Oct 9 2020, 9:53 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptOct 9 2020, 9:53 AM
Xqt triaged this task as Lowest priority.Oct 9 2020, 9:54 AM
Xqt added a parent task: T223529: Pywikibot good first bugs (tracking).
Udoka_Ugo added a subscriber: Udoka_Ugo.Oct 9 2020, 6:48 PM

Hi I am an outreachy intern I want to claim this issue

Pavithraes added a subscriber: Pavithraes.Oct 9 2020, 8:20 PM

@Udoka_Ugo Hi! You can claim the task by: Add Action -> Assign/Claim. See: https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Communicate_that_you_work_on_a_task

Udoka_Ugo claimed this task.Oct 10 2020, 9:04 AM

Thanks

Udoka_Ugo added a comment.Oct 10 2020, 11:10 PM

Hi I raised a P.R for this already thanks

gerritbot added a comment.Oct 11 2020, 6:43 AM

Change 633339 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] Replace all occurrences of "basestring" to "str"

https://gerrit.wikimedia.org/r/633339

gerritbot added a project: Patch-For-Review.Oct 11 2020, 6:43 AM
gerritbot added a comment.Oct 11 2020, 9:11 AM

Change 633351 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] doc: Replaced epytext type hints by annotation type hints

https://gerrit.wikimedia.org/r/633351

gerritbot added a comment.Oct 12 2020, 8:36 PM

Change 633577 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [doc] Replaced all "basestring" by "str" [doc] Replaced epytext hint for str by annotation text hint

https://gerrit.wikimedia.org/r/633577

gerritbot added a comment.Oct 15 2020, 9:58 AM

Change 634195 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

https://gerrit.wikimedia.org/r/634195

gerritbot added a comment.Oct 15 2020, 10:06 AM

Change 634196 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

https://gerrit.wikimedia.org/r/634196

gerritbot added a comment.Oct 15 2020, 10:15 AM

Change 634197 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

https://gerrit.wikimedia.org/r/634197

gerritbot added a comment.Oct 15 2020, 10:37 AM

Change 634201 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "doc: updated basestring to str"

https://gerrit.wikimedia.org/r/634201

gerritbot added a comment.Oct 15 2020, 10:48 AM

Change 633577 abandoned by Xqt:
[pywikibot/core@master] [doc] Replaced all "basestring" by "str" [doc] Replaced epytext hint for str by annotation text hint

Reason:
Outdated I guess and to hard to review

https://gerrit.wikimedia.org/r/633577

gerritbot added a comment.Oct 15 2020, 11:04 AM

Change 634205 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634205

gerritbot added a comment.Oct 15 2020, 11:13 AM

Change 634206 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634206

gerritbot added a comment.Oct 15 2020, 12:31 PM

Change 634216 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634216

gerritbot added a comment.Oct 15 2020, 12:32 PM

Change 634218 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634218

gerritbot added a comment.Oct 15 2020, 3:25 PM

Change 634201 merged by jenkins-bot:
[pywikibot/core@master] "doc: updated basestring to str"

https://gerrit.wikimedia.org/r/634201

Xqt mentioned this in rPWBCa75468f062dc: "doc: updated basestring to str".Oct 15 2020, 3:26 PM
gerritbot added a comment.Oct 15 2020, 3:34 PM

Change 634196 abandoned by Xqt:
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

Reason:
I guess this is already done with a75468f062dc6054e942d69165bbcca1490eea53

https://gerrit.wikimedia.org/r/634196

gerritbot added a comment.Oct 15 2020, 3:42 PM

Change 634274 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "[IMPR] Replaced basestring by str"

https://gerrit.wikimedia.org/r/634274

gerritbot added a comment.Oct 15 2020, 4:30 PM

Change 634285 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "[IMPR] Replaced basestring to str"

https://gerrit.wikimedia.org/r/634285

gerritbot added a comment.Oct 15 2020, 7:43 PM

Change 634327 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str [IMPR] Added annotation type hints

https://gerrit.wikimedia.org/r/634327

gerritbot added a comment.Oct 15 2020, 9:15 PM

Change 634344 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634344

gerritbot added a comment.Oct 15 2020, 9:24 PM

Change 634348 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634348

gerritbot added a comment.Oct 15 2020, 9:36 PM

Change 634351 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634351

gerritbot added a comment.Oct 16 2020, 6:17 AM

Change 634195 abandoned by Xqt:
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

Reason:
looks duplicated

https://gerrit.wikimedia.org/r/634195

gerritbot added a comment.Oct 16 2020, 9:20 AM

Change 634285 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring to str

https://gerrit.wikimedia.org/r/634285

Xqt mentioned this in rPWBC82671a22bb04: [IMPR] Replaced basestring to str.Oct 16 2020, 9:22 AM
gerritbot added a comment.Oct 16 2020, 11:12 AM

Change 634348 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634348

Udoka_Ugo mentioned this in rPWBC29c5eae19683: [IMPR] Replaced basestring by str.Oct 16 2020, 11:13 AM
gerritbot added a comment.Oct 16 2020, 12:53 PM

Change 634344 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634344

Udoka_Ugo mentioned this in rPWBCaa5636edb1bf: [IMPR] Replaced basestring by str.Oct 16 2020, 12:54 PM
gerritbot added a comment.Oct 17 2020, 8:55 AM

Change 634216 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634216

Udoka_Ugo mentioned this in rPWBC8705fd168931: [IMPR] Replaced basestring by str.Oct 17 2020, 8:57 AM
gerritbot added a comment.Oct 17 2020, 8:57 AM

Change 633351 abandoned by Xqt:
[pywikibot/core@master] Document:: Replaced epytext type hints by annotation type hints Update:: Replaced "basestring" with "str"

Reason:
I guess this is duplicated. Otherwise resore it. Anyway there are merge conflicts.

https://gerrit.wikimedia.org/r/633351

gerritbot added a comment.Oct 17 2020, 8:58 AM

Change 634351 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634351

Udoka_Ugo mentioned this in rPWBC3bb00da25ff6: [IMPR] Replaced basestring by str.Oct 17 2020, 8:58 AM
gerritbot added a comment.Oct 17 2020, 2:56 PM

Change 634274 abandoned by Udoka:
[pywikibot/core@master] [IMPR] Replaced basestring by str

Reason:
Conflict

https://gerrit.wikimedia.org/r/634274

gerritbot added a comment.Oct 17 2020, 3:45 PM

Change 634735 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634735

gerritbot added a comment.Oct 18 2020, 12:30 PM

Change 634218 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Replaced basestring by str

Reason:
Duplicate

https://gerrit.wikimedia.org/r/634218

gerritbot added a comment.Oct 18 2020, 3:32 PM

Change 634327 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634327

Xqt mentioned this in rPWBC4738ee6162f6: [IMPR] Replaced basestring by str.Oct 18 2020, 3:33 PM
gerritbot added a comment.Oct 18 2020, 3:35 PM

Change 634785 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634785

gerritbot added a comment.Oct 18 2020, 3:51 PM

Change 634735 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634735

Xqt mentioned this in rPWBCcab4e6bbbf2c: [IMPR] Replaced basestring by str.Oct 18 2020, 3:52 PM
gerritbot added a comment.Oct 18 2020, 4:44 PM

Change 634197 abandoned by Udoka:
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

Reason:
merge conflict

https://gerrit.wikimedia.org/r/634197

gerritbot added a comment.Oct 18 2020, 4:45 PM

Change 634205 abandoned by Udoka:
[pywikibot/core@master] [IMPR] Replaced basestring by str

Reason:
merge conflict

https://gerrit.wikimedia.org/r/634205

gerritbot added a comment.Oct 18 2020, 6:35 PM

Change 634206 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Replaced basestring by str

Reason:
Not a valid change. Most of them are already done.

https://gerrit.wikimedia.org/r/634206

gerritbot added a comment.Oct 18 2020, 6:39 PM

Change 634785 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634785

Xqt mentioned this in rPWBC65ec40a64a59: [IMPR] Replaced basestring by str.Oct 18 2020, 6:41 PM
Xqt removed a project: Patch-For-Review.Oct 20 2020, 5:52 AM

There are some remaining things:
https://codesearch.wmcloud.org/pywikibot/?q=basestring&i=nope&files=&repos=

Udoka_Ugo added a comment.Oct 20 2020, 10:50 AM

Yes I know this I would send in patches this evening.

gerritbot added a comment.Oct 20 2020, 8:17 PM

Change 635380 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/635380

gerritbot added a project: Patch-For-Review.Oct 20 2020, 8:17 PM
gerritbot added a comment.Oct 21 2020, 3:40 PM

Change 635380 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/635380

Xqt mentioned this in rPWBCab27edcb9920: [IMPR] Replaced basestring by str.Oct 21 2020, 3:46 PM
Xqt closed this task as Resolved.Oct 21 2020, 7:03 PM
Xqt removed a project: Patch-For-Review.

Thanks a lot Udoka

Udoka_Ugo mentioned this in T266332: [Outreachy 2020 - 2021 Proposal] Analyze community authored functions that build Wikipedia infoboxes and more.Oct 28 2020, 2:35 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL