Page MenuHomePhabricator

Replace all occurrences of "basestring"
Closed, ResolvedPublic

Description

Replace all occurrences of Python 2 basestring by str. But replace epydoc basestring type hints by typing annotation hints e.g.

def foo(bar):
"""Sample function.

@param bar: a sample Parameter
@type bar: basestring
"""
pass

should become

def foo(bar: str):
"""Sample function.

@param bar: a sample Parameter
"""
pass

https://codesearch.wmcloud.org/pywikibot/?q=basestring&i=nope&files=&repos=

Event Timeline

Xqt created this task.Oct 9 2020, 9:53 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptOct 9 2020, 9:53 AM
Xqt triaged this task as Lowest priority.Oct 9 2020, 9:54 AM

Hi I am an outreachy intern I want to claim this issue

Hi I raised a P.R for this already thanks

Change 633339 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] Replace all occurrences of "basestring" to "str"

https://gerrit.wikimedia.org/r/633339

Change 633351 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] doc: Replaced epytext type hints by annotation type hints

https://gerrit.wikimedia.org/r/633351

Change 633577 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [doc] Replaced all "basestring" by "str" [doc] Replaced epytext hint for str by annotation text hint

https://gerrit.wikimedia.org/r/633577

Change 634195 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

https://gerrit.wikimedia.org/r/634195

Change 634196 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

https://gerrit.wikimedia.org/r/634196

Change 634197 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

https://gerrit.wikimedia.org/r/634197

Change 634201 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "doc: updated basestring to str"

https://gerrit.wikimedia.org/r/634201

Change 633577 abandoned by Xqt:
[pywikibot/core@master] [doc] Replaced all "basestring" by "str" [doc] Replaced epytext hint for str by annotation text hint

Reason:
Outdated I guess and to hard to review

https://gerrit.wikimedia.org/r/633577

Change 634205 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634205

Change 634206 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634206

Change 634216 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634216

Change 634218 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634218

Change 634201 merged by jenkins-bot:
[pywikibot/core@master] "doc: updated basestring to str"

https://gerrit.wikimedia.org/r/634201

Change 634196 abandoned by Xqt:
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

Reason:
I guess this is already done with a75468f062dc6054e942d69165bbcca1490eea53

https://gerrit.wikimedia.org/r/634196

Change 634274 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "[IMPR] Replaced basestring by str"

https://gerrit.wikimedia.org/r/634274

Change 634285 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] "[IMPR] Replaced basestring to str"

https://gerrit.wikimedia.org/r/634285

Change 634327 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str [IMPR] Added annotation type hints

https://gerrit.wikimedia.org/r/634327

Change 634344 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634344

Change 634348 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634348

Change 634351 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634351

Change 634195 abandoned by Xqt:
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

Reason:
looks duplicated

https://gerrit.wikimedia.org/r/634195

Change 634285 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring to str

https://gerrit.wikimedia.org/r/634285

Change 634348 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634348

Change 634344 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634344

Change 634216 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634216

Change 633351 abandoned by Xqt:
[pywikibot/core@master] Document:: Replaced epytext type hints by annotation type hints Update:: Replaced "basestring" with "str"

Reason:
I guess this is duplicated. Otherwise resore it. Anyway there are merge conflicts.

https://gerrit.wikimedia.org/r/633351

Change 634351 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634351

Change 634274 abandoned by Udoka:
[pywikibot/core@master] [IMPR] Replaced basestring by str

Reason:
Conflict

https://gerrit.wikimedia.org/r/634274

Change 634735 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634735

Change 634218 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Replaced basestring by str

Reason:
Duplicate

https://gerrit.wikimedia.org/r/634218

Change 634327 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634327

Change 634785 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634785

Change 634735 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634735

Change 634197 abandoned by Udoka:
[pywikibot/core@master] "doc: UPDATED BASESTRING TO STR"

Reason:
merge conflict

https://gerrit.wikimedia.org/r/634197

Change 634205 abandoned by Udoka:
[pywikibot/core@master] [IMPR] Replaced basestring by str

Reason:
merge conflict

https://gerrit.wikimedia.org/r/634205

Change 634206 abandoned by Xqt:
[pywikibot/core@master] [IMPR] Replaced basestring by str

Reason:
Not a valid change. Most of them are already done.

https://gerrit.wikimedia.org/r/634206

Change 634785 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/634785

Yes I know this I would send in patches this evening.

Change 635380 had a related patch set uploaded (by Udoka; owner: Udoka):
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/635380

Change 635380 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] Replaced basestring by str

https://gerrit.wikimedia.org/r/635380

Xqt closed this task as Resolved.Oct 21 2020, 7:03 PM
Xqt removed a project: Patch-For-Review.

Thanks a lot Udoka