Link context not shown after editing a link
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 9 2020, 6:45 PM

Description

Click on a link
Click 'Edit'
Make a change to the link target
Click 'Done'

Observe that no link context is shown, when it should be.

This bug does not occur if you don't change the link target, or you are on mobile.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (e4bbec336)	mediawiki/extensions/VisualEditor	master	+1 -1
	Fix selection after editing annotations on desktop	VisualEditor/VisualEditor	master	+7 -1

Customize query in gerrit

Related Objects

Mentioned In: T113082: On applying new link annotation, place cursor outside of the link
Mentioned Here: rGVEDe4bbec3364e3: Merge "Fix selection after editing annotations on desktop"
T227630: [Pre-deployment bug] Adding an external link makes the edit card go away once it comes back to the document unlike other cases making it an inconsistent experience

Event Timeline

Esanders created this task.Oct 9 2020, 6:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2020, 6:45 PM

Strictly speaking a regression, but it's been broken for 4 years since https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/270315 (@dchan)

• ppelberg subscribed.Oct 9 2020, 6:49 PM

Similar previous bug when inserting links: T227630

Change 633234 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Fix selection after editing annotations on desktop

https://gerrit.wikimedia.org/r/633234

gerritbot added a project: Patch-For-Review.Oct 9 2020, 7:30 PM

Esanders claimed this task.Oct 9 2020, 7:40 PM

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Demo: https://patchdemo.wmflabs.org/wikis/30c90c4925265b027f04c404a1933867/w/index.php/Main_Page?veaction=edit

Change 633234 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix selection after editing annotations on desktop

https://gerrit.wikimedia.org/r/633234

Change 639332 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e4bbec336)

https://gerrit.wikimedia.org/r/639332

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 5 2020, 12:55 AM

matmarex edited projects, added Skipped QA; removed Patch-For-Review.

Change 639332 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e4bbec336)

https://gerrit.wikimedia.org/r/639332

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.18; 2020-11-17).Nov 5 2020, 2:00 AM

I seem to be seeing the same experience that inspired this bug to be filed:

Open VE
Click an existing link
Observe the link context item
Click Edit within the link context item
Change the link target by of altering the text in the search field and clicking an item from the "search results"
❗️ Land back in the article; no link context item appears

See: https://youtu.be/jgD3VwU9lko .