Page MenuHomePhabricator

[Testflight] Crash in Significant Events fetching
Closed, ResolvedPublicBUG REPORT

Description

Certain articles crash here. We need to keep an eye out for it and fix the next time we see it.

Test Steps

This was caused by trying to load the Article as a Living Doc experiment on an article with a special character in it's title. I don't think any of those articles are in our allowlist anymore, but keep an eye out for this, it would look like a crash as soon as a user is pushed to the article view.

Event Timeline

There's also a similar crash on this build:

Also related to URLComponents.percentEncodedPath.setter but this comes through Router rather than SignificantEventsFetcher.significantEventsURL

This crash log from TF represents some more encoding issues on the Significant Events endpoint from Matt, Carolyn, and Joe. From Joe, a URL that causes it to crash currently is: https://en.wikipedia.org/wiki/Laoco%C3%B6n_and_His_Sons

LGoto triaged this task as Medium priority.Oct 27 2020, 8:04 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
ABorbaWMF subscribed.

I am not seeing the crash on 6.7.3 (1786), but that may be because the article Laocoön and His Sons is not showing AALD anymore. I used some of the articles with special characters (like parentheses) and they worked fine. I have not found any articles with ö type characters that are also displaying AALD.

JMinor claimed this task.