Page MenuHomePhabricator

Cosmos skin: Fix all remaining ESLint issues
Closed, ResolvedPublic

Description

Rules that were disabled initially and need to be fixed are listed below. Work will be split between @Universal_Omega and @SamanthaNguyen.

NOTE: Do not try to fix everything at once! One (small) patch at a time for a group of related rules.
comma-dangle
computed-property-spacing
eqeqeq
indent
no-jquery/no-event-shorthand
no-jquery/no-global-selector
no-jquery/no-ready-shorthand
no-mixed-spaces-and-tabs
no-multiple-empty-lines
no-trailing-spaces
no-undef
no-underscore-dangle
no-unused-vars
no-useless-escape
one-var
operator-linebreak
quotes
semi
space-before-function-paren
space-in-parens
vars-on-top
wrap-iife

Event Timeline

SamanthaNguyen created this task.
SamanthaNguyen lowered the priority of this task from Medium to Low.Oct 14 2020, 2:33 AM

Change 655393 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/skins/Cosmos@master] Enable eslint checks

https://gerrit.wikimedia.org/r/655393

Change 655393 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Enable eslint checks

https://gerrit.wikimedia.org/r/655393

Universal_Omega claimed this task.
Universal_Omega moved this task from Incoming / Backlog to Done on the Cosmos board.