Page MenuHomePhabricator

Cosmos skin: Fix all remaining Stylelint issues
Closed, ResolvedPublic

Description

Rules that were disabled initially and need to be fixed are listed below. Work will be split between @Universal_Omega and @SamanthaNguyen.

NOTE: Do not try to fix everything at once! One (small) patch at a time for a group of related rules.
  • at-rule-empty-line-before
  • block-closing-brace-empty-line-before
  • block-opening-brace-newline-after
  • block-closing-brace-newline-before
  • block-opening-brace-newline-before
  • block-opening-brace-space-before
  • color-hex-case
  • color-hex-length
  • color-named
  • comment-whitespace-inside
  • declaration-colon-space-after
  • declaration-block-no-duplicate-properties
  • declaration-block-no-redundant-longhand-properties
  • declaration-block-semicolon-newline-after
  • declaration-block-trailing-semicolon
  • declaration-no-important
  • declaration-property-value-blacklist
  • declaration-property-value-disallowed-list
  • font-family-name-quotes
  • font-weight-notation
  • function-comma-space-after
  • function-blacklist
  • function-parentheses-space-inside
  • function-url-quotes
  • indentation
  • length-zero-no-unit
  • max-empty-lines
  • media-feature-colon-space-after
  • media-feature-parentheses-space-inside
  • no-descending-specificity
  • no-duplicate-selectors
  • no-eol-whitespace
  • no-missing-end-of-source-newline
  • number-leading-zero
  • rule-empty-line-before
  • selector-attribute-brackets-space-inside
  • selector-combinator-space-after
  • selector-list-comma-newline-after
  • selector-list-comma-space-after
  • selector-max-id
  • selector-no-vendor-prefix
  • selector-pseudo-class-parentheses-space-inside
  • selector-pseudo-element-colon-notation
  • string-quotes
  • unit-blacklist
  • unit-disallowed-list
  • value-keyword-case
  • value-list-comma-space-after

Event Timeline

SamanthaNguyen created this task.
SamanthaNguyen lowered the priority of this task from Medium to Low.Oct 14 2020, 2:33 AM

Change 655944 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/skins/Cosmos@master] Cosmos: Fix some stylelint issues

https://gerrit.wikimedia.org/r/655944

Change 655944 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Cosmos: Fix some stylelint issues

https://gerrit.wikimedia.org/r/655944

This comment has been deleted.

Change 655945 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/skins/Cosmos@master] [Stylelint]: Fix color-named and declaration-block-no-redundant-longhand-properties

https://gerrit.wikimedia.org/r/655945

Change 655945 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] [Stylelint]: Fix color-named and declaration-block-no-redundant-longhand-properties

https://gerrit.wikimedia.org/r/655945

Change 656287 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/skins/Cosmos@master] [Stylelint]: Fix font-weight-notation and font-family-name-quotes

https://gerrit.wikimedia.org/r/656287

Change 656287 merged by Universal Omega:
[mediawiki/skins/Cosmos@master] [Cosmos]: Fix more stylelint issues

https://gerrit.wikimedia.org/r/656287

Universal_Omega claimed this task.
Universal_Omega moved this task from In Progress to Done on the Cosmos board.