Maniphest T265197

Make class UserrightsPage a real special page and move all helper function to own service
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	Umherirrender
	Oct 10 2020, 8:32 PM

Tags

Referenced Files

None

Subscribers

Description

At the moment the Special:UserRights is instanced outside of the SpecialPageFactory to call some of the function for code sharing between special page, api and linking in skin and some other special pages

It seems there are mostly calling userCanChangeRights or fetchUser

https://codesearch.wmcloud.org/search/?q=UserrightsPage&i=nope&files=&repos=

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+524 -150	[WIP] Introduce ChangeUserGroups command

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T259960 Inject services into API modules and special pages
		Open		Daimona	T265197 Make class UserrightsPage a real special page and move all helper function to own service

Event Timeline

Umherirrender created this task.Oct 10 2020, 8:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2020, 8:32 PM

Umherirrender added a parent task: T259960: Inject services into API modules and special pages.Oct 10 2020, 8:32 PM

Umherirrender mentioned this in T265298: Provide a public method for logging user rights changes.Oct 12 2020, 7:02 PM

DannyS712 mentioned this in T263207: The `UserrightsPage` class is not safe to extend.Nov 24 2020, 12:07 AM

Umherirrender removed a subscriber: Umherirrender.Apr 4 2021, 7:52 PM

Izno edited projects, added MediaWiki-User-management; removed MediaWiki-Special-pages.Jun 19 2021, 7:08 PM

Zabe added a subscriber: Zabe.Nov 14 2021, 10:27 AM

Daimona claimed this task.Feb 13 2022, 4:22 PM

Change 762118 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] [WIP] Introduce ChangeUserGroups command

https://gerrit.wikimedia.org/r/762118

gerritbot added a project: Patch-For-Review.Feb 13 2022, 4:56 PM

• taavi added a subscriber: • taavi.Feb 22 2022, 12:37 AM