Page MenuHomePhabricator
Create Task
Maniphest T265197

Make class SpecialUserRights a real special page and move all helper function to own service
Open, Needs TriagePublic
Actions

Description

At the moment the Special:UserRights is instanced outside of the SpecialPageFactory to call some of the function for code sharing between special page, api and linking in skin and some other special pages

It seems there are mostly calling userCanChangeRights or fetchUser

https://codesearch.wmcloud.org/search/?q=%28UserrightsPage%7CSpecialUserRights%29&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
[WIP] Introduce ChangeUserGroups commandmediawiki/coremaster+524 -150
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Oct 10 2020, 8:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2020, 8:32 PM
Umherirrender added a parent task: T259960: Inject services into API modules and special pages.Oct 10 2020, 8:32 PM
Umherirrender mentioned this in T265298: Provide a public method for logging user rights changes.Oct 12 2020, 7:02 PM
DannyS712 mentioned this in T263207: The `UserrightsPage` class is not safe to extend.Nov 24 2020, 12:07 AM
Umherirrender unsubscribed.Apr 4 2021, 7:52 PM
Izno edited projects, added MediaWiki-User-management; removed MediaWiki-Special-pages.Jun 19 2021, 7:08 PM
Zabe subscribed.Nov 14 2021, 10:27 AM
Daimona claimed this task.Feb 13 2022, 4:22 PM
gerritbot added a comment.Feb 13 2022, 4:56 PM

Change 762118 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] [WIP] Introduce ChangeUserGroups command

https://gerrit.wikimedia.org/r/762118

gerritbot added a project: Patch-For-Review.Feb 13 2022, 4:56 PM
taavi subscribed.Feb 22 2022, 12:37 AM
Daimona removed Daimona as the assignee of this task.Sep 23 2023, 4:36 PM
Daimona subscribed.
Umherirrender renamed this task from Make class UserrightsPage a real special page and move all helper function to own service to Make class SpecialUserRights a real special page and move all helper function to own service.Sep 23 2023, 9:50 PM
Umherirrender updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL