Page MenuHomePhabricator

Cosmos skin: Don't pass string variables by reference in CosmosTemplate
Closed, ResolvedPublic

Description

This ultimately makes debugging harder. Each method should be returning a string instead of modifying a string variable, and then use string concatenation in the main function.

Event Timeline

Change 633582 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

Change 633582 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

Change 634143 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] CosmosTemplate: Don't pass string parameter by reference

https://gerrit.wikimedia.org/r/634143

SamanthaNguyen triaged this task as Medium priority.Oct 15 2020, 5:02 AM
SamanthaNguyen moved this task from Incoming / Backlog to In Progress on the Cosmos board.

Change 634143 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] CosmosTemplate: Don't pass string parameter by reference

https://gerrit.wikimedia.org/r/634143

SamanthaNguyen closed this task as Resolved.Oct 15 2020, 7:31 PM
SamanthaNguyen claimed this task.
SamanthaNguyen moved this task from In Progress to Done on the Cosmos board.
SamanthaNguyen removed a project: Patch-For-Review.