Page MenuHomePhabricator
Create Task
Maniphest T265232

Cosmos skin: Don't pass string variables by reference in CosmosTemplate
Closed, ResolvedPublic
Actions

Description

This ultimately makes debugging harder. Each method should be returning a string instead of modifying a string variable, and then use string concatenation in the main function.

Details

SubjectRepoBranchLines +/-
CosmosTemplate: Don't pass string parameter by referencemediawiki/skins/Cosmosmaster+127 -65
Technical debt cleanup: Remove unused parameters from methodsmediawiki/skins/Cosmosmaster+40 -76
Customize query in gerrit

Related Objects
Search...

Event Timeline

SamanthaNguyen created this task.Oct 12 2020, 4:33 AM
gerritbot added a comment.Oct 12 2020, 10:21 PM

Change 633582 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

gerritbot added a project: Patch-For-Review.Oct 12 2020, 10:21 PM
SamanthaNguyen added a parent task: T264908: Convert Cosmos to use HTML templating.Oct 12 2020, 10:28 PM
gerritbot added a comment.Oct 13 2020, 6:02 PM

Change 633582 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] Technical debt cleanup: Remove unused parameters from methods

https://gerrit.wikimedia.org/r/633582

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2020, 6:10 PM
SamanthaNguyen moved this task from Code hygiene to Incoming / Backlog on the Cosmos board.Oct 15 2020, 12:11 AM
gerritbot added a comment.Oct 15 2020, 4:59 AM

Change 634143 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Cosmos@master] CosmosTemplate: Don't pass string parameter by reference

https://gerrit.wikimedia.org/r/634143

gerritbot added a project: Patch-For-Review.Oct 15 2020, 4:59 AM
SamanthaNguyen triaged this task as Medium priority.Oct 15 2020, 5:02 AM
SamanthaNguyen moved this task from Incoming / Backlog to In Progress on the Cosmos board.
gerritbot added a comment.Oct 15 2020, 7:31 PM

Change 634143 merged by jenkins-bot:
[mediawiki/skins/Cosmos@master] CosmosTemplate: Don't pass string parameter by reference

https://gerrit.wikimedia.org/r/634143

SamanthaNguyen closed this task as Resolved.Oct 15 2020, 7:31 PM
SamanthaNguyen claimed this task.
SamanthaNguyen moved this task from In Progress to Done on the Cosmos board.
SamanthaNguyen removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL