Page MenuHomePhabricator

🎬 wpde-mobile-01 | Address provision options | ⏰ Nov 3rd
Open, Needs TriagePublic2 Estimated Story Points

Description

This test uses the banners of mobile-de-03 on wikipedia.de.

Acceptance Criteria

  • The banners for mobile-de-03 are ported to be used on wikipedia.de.
  • The banners also contain the progress bar and the "campaign day sentence" (the latter in the mini banner as well as in the expanded one).

Implementation notes

  • Only the javascript file is to be moved to the built banners repository.
  • Campaign configuration is done in campaigns.yml in the same repository.
  • Deployment of this should happen automatically every 15 minutes (as setup in the crontab of deploy on bruce.wikipedia.de).

Event Timeline

Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptOct 12 2020, 8:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen updated the task description. (Show Details)Oct 12 2020, 10:37 AM
kai.nissen set the point value for this task to 3.
kai.nissen updated the task description. (Show Details)
kai.nissen updated the task description. (Show Details)
kai.nissen renamed this task from 🎬 wpde-mobile-01 | Address provision options | ⏰ Nov 3th to 🎬 wpde-mobile-01 | Address provision options | ⏰ Nov 3rd.Oct 21 2020, 12:13 PM
kai.nissen updated the task description. (Show Details)Oct 21 2020, 12:28 PM
kai.nissen changed the point value for this task from 3 to 8.

@CorinnaHillebrand_WMDE
I had a look at the banners and found some issues:

  • The submit button has some retro borders.
  • In Chromium, there are scrollbars around amount options
  • The slide with the progress bar should be the first slide.
  • The button labels are not centered vertically.

@kai.nissen I fixed the stuff.

The progressbar should animate properly now, too, in mini+fullpage banner.
What we were not sure about is how the progressbar should behave currently during early phase and "late progress" phase and so on. To check how it currently looks you can replace the following line in wikipedia.de/mobile/banner_ctrl.js:
const campaignParameters = createCampaignParameters( );

with

import { DevCampaignParameters } from '../../shared/campaign_parameters';
const campaignParameters = createCampaignParameters( [ new DevCampaignParameters() ] );

to use the campaign parameters from shared/global_banner_settings.js.

kai.nissen added a comment.EditedOct 24 2020, 5:24 PM

@CorinnaHillebrand_WMDE Thanks for fixing. The button labels still seem a little closer to the top border. I also just noticed that there is too much space added to the top (looks like twice the banner height).

At the beginning of the campaign, the "Nur noch n Tage" label is not displayed. Last year, the progress bar looked like this:

The filled area seems to have a minimum width that is actually not necessary and may be a leftover from when the collected amount was displayed inside the progress bar.

kai.nissen updated the task description. (Show Details)Oct 26 2020, 11:08 AM
kai.nissen changed the point value for this task from 8 to 2.

@CorinnaHillebrand_WMDE
Sorry, the vertical alignment of the button labels looks fine on my mobile device. So it's only the change to the progress bar and the issue of too much space added or the banner.

gabriel-wmde moved this task from Heap to Doing on the WMDE-FUN-Funban-2020 board.Oct 26 2020, 3:28 PM

@kai.nissen let me know when you don't see any issues left, then I will push that code to the banner server

@CorinnaHillebrand_WMDE Till noticed that the automatic sliding stops on the third slide (both control and variant). Can you have another look?

@CorinnaHillebrand_WMDE In the first slide the donation target is displayed twice. Could you change the progress bar label on the right to display the remaining amount?