Page MenuHomePhabricator
Create Task
Maniphest T265292

Remove unused arguments from TermValidatorFactory::getFingerprintValidator
Closed, ResolvedPublic
Actions

Description

  • TermValidatorFactory::getFingerprintValidator() has two arguments ($entityType and entityId $entityId) that are now unused
  • TermValidatorFactory::getFingerprintUniquenessValidator(), a separate method, also exists; its documentation still talks about the old and new term store, but the old term store is no more
  • the FingerprintValidator interface (returned by getFingerprintValidator(), but not by getFingerprintUniquenessValidator()) is documented as “intended particularly for uniqueness checks”, but none of the remaining implementations check uniqueness (that was “old term store stuff”)
  • the CompositeFingerprintValidator class, one of the implementations of that interface, is unused and can be removed
  • the NullFingerprintValidator class, another of the implementations of that interface, is unused except in tests
  • (there is only one other class implementing that interface, LabelDescriptionNotEqualValidator, so maybe the interface can be removed completely?)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+0 -1Remove a TODO that no longer applies
mediawiki/extensions/Wikibasemaster+2 -3Remove outdated parts of change op comments
mediawiki/extensions/Wikibasemaster+18 -30Update LabelDescriptionNotEqualValidator usage
mediawiki/extensions/Wikibasemaster+4 -198Remove unused validators
mediawiki/extensions/Wikibasemaster+9 -37Cleanup TermValidatorFactory
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 12 2020, 4:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2020, 4:08 PM
Lucas_Werkmeister_WMDE mentioned this in T264288: Remove wb_terms-based conflict detection.Oct 12 2020, 4:08 PM
Lucas_Werkmeister_WMDE added a comment.Oct 12 2020, 4:26 PM

Hm, I think there are a few more things to clean up in this area:

  • TermValidatorFactory::getFingerprintValidator() has unused parameters (original task description)
  • TermValidatorFactory::getFingerprintUniquenessValidator(), a separate method, also exists; its documentation still talks about the old and new term store, but the old term store is no more
  • the FingerprintValidator interface (returned by getFingerprintValidator(), but not by getFingerprintUniquenessValidator()) is documented as “intended particularly for uniqueness checks”, but none of the remaining implementations check uniqueness (that was “old term store stuff”)
  • the CompositeFingerprintValidator class, one of the implementations of that interface, is unused and can be removed
  • the NullFingerprintValidator class, another of the implementations of that interface, is unused except in tests
  • (there is only one other class implementing that interface, LabelDescriptionNotEqualValidator, so maybe the interface can be removed completely?)
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Oct 12 2020, 4:48 PM
• toan claimed this task.Oct 13 2020, 7:23 AM
• toan moved this task from To do to Doing on the Wikibase wb_terms leftovers 2020 board.
• toan moved this task from Doing to To do on the Wikibase wb_terms leftovers 2020 board.Oct 13 2020, 7:29 AM
• toan moved this task from To do to Doing on the Wikibase wb_terms leftovers 2020 board.Oct 13 2020, 1:42 PM
gerritbot added a comment.Oct 13 2020, 2:20 PM

Change 633745 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] wip: Cleanup TermValidatorFactory

https://gerrit.wikimedia.org/r/633745

gerritbot added a project: Patch-For-Review.Oct 13 2020, 2:20 PM
• toan updated the task description. (Show Details)Oct 13 2020, 2:22 PM
• toan updated the task description. (Show Details)
gerritbot added a comment.Oct 14 2020, 6:53 AM

Change 633942 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] Remove unused validators

https://gerrit.wikimedia.org/r/633942

gerritbot added a comment.Oct 14 2020, 9:28 AM

Change 633961 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] Update labelDescription validator usage

https://gerrit.wikimedia.org/r/633961

• toan moved this task from Doing to Peer Review on the Wikibase wb_terms leftovers 2020 board.Oct 14 2020, 10:25 AM
gerritbot added a comment.Oct 14 2020, 3:48 PM

Change 634046 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove outdated parts of change op comments

https://gerrit.wikimedia.org/r/634046

gerritbot added a comment.Oct 14 2020, 4:17 PM

Change 633745 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Cleanup TermValidatorFactory

https://gerrit.wikimedia.org/r/633745

gerritbot added a comment.Oct 14 2020, 4:27 PM

Change 633942 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove unused validators

https://gerrit.wikimedia.org/r/633942

gerritbot added a comment.Oct 14 2020, 4:33 PM

Change 633961 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update LabelDescriptionNotEqualValidator usage

https://gerrit.wikimedia.org/r/633961

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 14 2020, 5:00 PM
gerritbot added a comment.Oct 14 2020, 5:16 PM

Change 634046 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove outdated parts of change op comments

https://gerrit.wikimedia.org/r/634046

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2020, 6:10 PM
• toan moved this task from Peer Review to Verification on the Wikibase wb_terms leftovers 2020 board.Oct 15 2020, 9:02 AM
gerritbot added a comment.Oct 15 2020, 3:27 PM

Change 634272 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove a TODO that no longer applies

https://gerrit.wikimedia.org/r/634272

gerritbot added a project: Patch-For-Review.Oct 15 2020, 3:27 PM
Lucas_Werkmeister_WMDE moved this task from Verification to Peer Review on the Wikibase wb_terms leftovers 2020 board.Oct 15 2020, 3:28 PM

Looked through the validator factory and found two more things, with patches. Remove unused parameter is not really related to this task (the parameter had been unused for much longer), but remove a TODO is, so moving back to review for (hopefully) just a short while.

gerritbot added a comment.Oct 15 2020, 6:43 PM

Change 634272 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove a TODO that no longer applies

https://gerrit.wikimedia.org/r/634272

• toan moved this task from Peer Review to Verification on the Wikibase wb_terms leftovers 2020 board.Oct 16 2020, 8:20 AM
WMDE-leszek closed this task as Resolved.Oct 16 2020, 9:12 AM
WMDE-leszek moved this task from Verification to Done on the Wikibase wb_terms leftovers 2020 board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL