GlobalUsage should not extend core's SpecialWantedfiles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Oct 12 2020, 7:35 PM

Description

The class WantedFilesPage is extended in extension, but the class is not part of the stable policy and that does not allow to extend it.

I am not sure what the best way is for the extension

https://codesearch.wmcloud.org/search/?q=extends%5Cs%2BWantedFilesPage%5Cb&i=nope&files=&repos=

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Simplify special pages now that GlobalUsage no longer extends them	mediawiki/core	master	+13 -23
	Do not extend core special page classes that aren't stable to extend	mediawiki/extensions/GlobalUsage	master	+74 -16

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T259960 Inject services into API modules and special pages
		Resolved		matmarex	T265301 GlobalUsage should not extend core's SpecialWantedfiles

Event Timeline

Umherirrender created this task.Oct 12 2020, 7:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2020, 7:35 PM

Umherirrender added a parent task: T259960: Inject services into API modules and special pages.Oct 12 2020, 7:35 PM

Umherirrender unsubscribed.Apr 4 2021, 7:52 PM

Krinkle renamed this task from Stop extending core's SpecialWantedfiles to GlobalUsage should not extend core's SpecialWantedfiles.Oct 13 2021, 7:08 PM

Krinkle removed a project: MediaWiki-Special-pages.Oct 13 2021, 7:54 PM

Change 851104 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/GlobalUsage@master] Do not extend core special page classes that aren't stable to extend

https://gerrit.wikimedia.org/r/851104

gerritbot added a project: Patch-For-Review.Oct 31 2022, 4:04 PM

Change 851104 merged by jenkins-bot:

[mediawiki/extensions/GlobalUsage@master] Do not extend core special page classes that aren't stable to extend

https://gerrit.wikimedia.org/r/851104

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2022, 7:31 PM

matmarex closed this task as Resolved.Nov 16 2022, 7:15 PM

matmarex claimed this task.

Change 857752 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Simplify special pages now that GlobalUsage no longer extends them

https://gerrit.wikimedia.org/r/857752

gerritbot added a project: Patch-For-Review.Nov 16 2022, 7:23 PM

Change 857752 merged by jenkins-bot: