Page MenuHomePhabricator

Update extensions that extend core SpecialRandompage class
Closed, ResolvedPublic

Description

The class RandomPage is extended in extension, but the class is not part of the stable policy and that does not allow to extend it.

I am not sure what the best way is for the extension
I am not sure if it is okay to extend inside core for core special pages

https://codesearch.wmcloud.org/search/?q=extends%5Cs%2BRandomPage%5Cb&i=nope&files=&repos=

Event Timeline

It should, generally, be okay for core to extend core classes, but I agree that extensions should not be extending this, since it is not stable to extend

Krinkle renamed this task from Stop extending core's SpecialRandompage to Update extensions that extend core SpecialRandompage class.Jun 19 2021, 3:05 AM
Krinkle removed a project: MediaWiki-Special-pages.

Change 957667 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/WikimediaIncubator@master] Inject services to SpecialRandomPage

https://gerrit.wikimedia.org/r/957667

Change 957668 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Deprecate SpecialRandomPage::__construct without injected services

https://gerrit.wikimedia.org/r/957668

Change 957667 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Inject services to SpecialRandomPage

https://gerrit.wikimedia.org/r/957667

Change 957791 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/RandomInCategory@master] Inject services for SpecialRandomPage::__construct

https://gerrit.wikimedia.org/r/957791

Change 957791 merged by jenkins-bot:

[mediawiki/extensions/RandomInCategory@master] Inject services for SpecialRandomPage::__construct

https://gerrit.wikimedia.org/r/957791

Change 957668 merged by jenkins-bot:

[mediawiki/core@master] Deprecate SpecialRandomPage::__construct without injected services

https://gerrit.wikimedia.org/r/957668

Change 980945 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] SpecialRandomPage: Remove deprecated stuff

https://gerrit.wikimedia.org/r/980945

matmarex subscribed.

Change 980945 merged by jenkins-bot:

[mediawiki/core@master] SpecialRandomPage: Remove deprecated stuff

https://gerrit.wikimedia.org/r/980945