Page MenuHomePhabricator
Create Task
Maniphest T265311

Inject UserFactory into classes using DI
Closed, ResolvedPublic
Actions

Description

Now that the service exists, it should be used where possible

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Inject UserFactory into PermissionManagermediawiki/coremaster+13 -4
Inject UserFactory into SpecialEmailInvalidatemediawiki/coremaster+23 -3
Inject UserFactory into SpecialConfirmEmailmediawiki/coremaster+14 -3
Inject UserFactory into WatchedItemQueryServicemediawiki/coremaster+17 -2
Inject UserFactory into BlockErrorFormattermediawiki/coremaster+18 -2
Inject UserFactory into ActorMigrationmediawiki/coremaster+23 -3
Inject services into ApiValidatePasswordmediawiki/coremaster+37 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Oct 12 2020, 8:48 PM
gerritbot added a comment.Oct 12 2020, 8:49 PM

Change 633492 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject UserFactory into BlockErrorFormatter

https://gerrit.wikimedia.org/r/633492

gerritbot added a project: Patch-For-Review.Oct 12 2020, 8:49 PM

Change 633493 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject UserFactory into ActorMigration

https://gerrit.wikimedia.org/r/633493

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Oct 12 2020, 8:49 PM
gerritbot added a comment.Oct 12 2020, 8:51 PM

Change 633494 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject UserFactory into PermissionManager

https://gerrit.wikimedia.org/r/633494

gerritbot added a comment.Oct 12 2020, 8:57 PM

Change 633495 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject services into ApiValidatePassword

https://gerrit.wikimedia.org/r/633495

gerritbot added a comment.Oct 12 2020, 9:32 PM

Change 633496 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject UserFactory into WatchedItemQueryService

https://gerrit.wikimedia.org/r/633496

gerritbot added a comment.Oct 13 2020, 7:32 PM

Change 633495 merged by jenkins-bot:
[mediawiki/core@master] Inject services into ApiValidatePassword

https://gerrit.wikimedia.org/r/633495

gerritbot added a comment.Oct 13 2020, 7:56 PM

Change 633493 merged by jenkins-bot:
[mediawiki/core@master] Inject UserFactory into ActorMigration

https://gerrit.wikimedia.org/r/633493

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 13 2020, 8:00 PM
gerritbot added a comment.Oct 13 2020, 8:37 PM

Change 633492 merged by jenkins-bot:
[mediawiki/core@master] Inject UserFactory into BlockErrorFormatter

https://gerrit.wikimedia.org/r/633492

• Clarakosi moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.Oct 15 2020, 5:03 PM
gerritbot added a comment.Oct 15 2020, 5:27 PM

Change 633496 merged by jenkins-bot:
[mediawiki/core@master] Inject UserFactory into WatchedItemQueryService

https://gerrit.wikimedia.org/r/633496

gerritbot added a comment.Oct 15 2020, 5:35 PM

Change 634257 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject UserFactory into SpecialConfirmEmail

https://gerrit.wikimedia.org/r/634257

gerritbot added a comment.Oct 15 2020, 5:39 PM

Change 634258 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject UserFactory into SpecialEmailInvalidate

https://gerrit.wikimedia.org/r/634258

gerritbot added a comment.Oct 15 2020, 7:30 PM

Change 634257 merged by jenkins-bot:
[mediawiki/core@master] Inject UserFactory into SpecialConfirmEmail

https://gerrit.wikimedia.org/r/634257

gerritbot added a comment.Oct 15 2020, 9:00 PM

Change 634258 merged by jenkins-bot:
[mediawiki/core@master] Inject UserFactory into SpecialEmailInvalidate

https://gerrit.wikimedia.org/r/634258

JJMC89 moved this task from Backlog to Other on the MediaWiki-User-management board.Nov 28 2020, 4:38 PM
gerritbot added a comment.May 26 2021, 8:01 AM

Change 633494 abandoned by DannyS712:

[mediawiki/core@master] Inject UserFactory into PermissionManager

Reason:

https://gerrit.wikimedia.org/r/633494

DannyS712 closed this task as Resolved.May 26 2021, 8:01 AM

Going to label this as done, injected into a bunch of places but now being superseded by the migration to authority

Maintenance_bot removed a project: Patch-For-Review.May 26 2021, 8:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits