Page MenuHomePhabricator

Pywikibot generate_family_file.py allows names with underscores
Closed, ResolvedPublic

Description

Aug 19 2020 pywikibot
generate_family_file.py http://newwiki33.priory newwiki_33
and no error

generate_user_files.py
select newwiki_33

Traceback (most recent call last):

File "/home/john/bin/pywikibot/core/generate_user_files.py", line 467, in <module>
  main()
File "/home/john/bin/pywikibot/core/generate_user_files.py", line 459, in main
  force=force)
File "/home/john/bin/pywikibot/core/generate_user_files.py", line 306, in create_user_config
  main_family, main_code, main_username, force=force))]
File "/home/john/bin/pywikibot/core/generate_user_files.py", line 123, in get_site_and_lang
  fam = pywikibot.family.Family.load(fam)
File "/data/priory1/home/john/bin/pywikibot/core1/pywikibot/tools/__init__.py", line 1740, in wrapper
  return obj(*__args, **__kw)
File "/data/priory1/home/john/bin/pywikibot/core1/pywikibot/family.py", line 976, in load
  'Name of family %s must be ASCII characters and digits' % fam

AssertionError: Name of family newwiki_33 must be ASCII characters and digits

Two issues

  1. underscore is an ascii character, so change the check or error message
  1. The generate_user_files.py checks for valid characters should be applied to generate_family_file.py

Event Timeline

Change 633805 had a related patch set uploaded (by Mpaa; owner: Mpaa):
[pywikibot/core@master] [bugfix] accept only valid names in generate_family_file.py

https://gerrit.wikimedia.org/r/633805

Xqt claimed this task.
Xqt reassigned this task from Xqt to Mpaa.
Xqt subscribed.

Change 633805 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] accept only valid names in generate_family_file.py

https://gerrit.wikimedia.org/r/633805