Page MenuHomePhabricator
Create Task
Maniphest T265361

OAuth extension - get rid of isAllowed() deprecated method
Closed, DuplicatePublic
Actions

Description

The isAllowed() deprecated method is to be exchnaged into:

MediaWikiServices::getInstance()->getPermissionManager()->userHasRight(...)

as it's stated in the method's annotation.

Related Objects

Event Timeline

Art.tsymbar created this task.Oct 13 2020, 1:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2020, 1:51 PM
Helga_sf triaged this task as Low priority.Oct 13 2020, 2:07 PM
Ammarpad subscribed.Oct 13 2020, 9:41 PM

Have wrote patch for this in T246567

Art.tsymbar added a comment.Oct 19 2020, 9:07 AM
In T265361#6540657, @Ammarpad wrote:

Have wrote patch for this in T246567

True, but there is 1 place with "isAllowed()" usage to be exchanged.

Art.tsymbar reassigned this task from Art.tsymbar to Vlad.shapik.Oct 19 2020, 9:08 AM
Peter.ovchyn removed Vlad.shapik as the assignee of this task.Oct 21 2020, 12:35 PM
Peter.ovchyn added a subscriber: Vlad.shapik.
Aklapper added a comment.Oct 23 2023, 12:05 PM
In T265361#6559442, @Art.tsymbar wrote:

True, but there is 1 place with "isAllowed()" usage to be exchanged.

OAuth has no isAllowed in its codebase anymore since Ammarpad's patch in T246567 got merged so this is a dup.
If something else was meant, please elaborate.

Aklapper closed this task as a duplicate of T246567: Avoid use of User::isAllowed.Oct 23 2023, 12:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits